fix(operations): Make Operations a manual client [gax-java] #1282
Conversation
@@ -111,7 +109,6 @@ | |||
* </code> | |||
* </pre> | |||
*/ | |||
@Generated("by GAPIC v0.0.5") | |||
@BetaApi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it still Beta?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed for this and OperationSettings. I left them in for the stub classes (since they're everywhere across the dependent APIs), but LMK if we should remove them in one fell swoop.
The following files are not formatted properly: FAILURE: Build failed with an exception.
|
Codecov Report
@@ Coverage Diff @@
## master #1282 +/- ##
=========================================
Coverage 79.19% 79.19%
Complexity 1235 1235
=========================================
Files 209 209
Lines 5378 5378
Branches 454 454
=========================================
Hits 4259 4259
Misses 939 939
Partials 180 180
Continue to review full report at Codecov.
|
Done. |
This client has been actively supporting many APIs for a while, and contains manual logic to that effect. Removing the "Auto-generated" mentioned in comments will help us identify and support this as a manually-written client, and ensures we won't clobber it with a newly Gapic-generated one by mistake.