Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

fix(operations): Make Operations a manual client [gax-java] #1282

Merged
merged 7 commits into from Feb 2, 2021

Conversation

miraleung
Copy link
Contributor

This client has been actively supporting many APIs for a while, and contains manual logic to that effect. Removing the "Auto-generated" mentioned in comments will help us identify and support this as a manually-written client, and ensures we won't clobber it with a newly Gapic-generated one by mistake.

@miraleung miraleung requested review from a team as code owners January 28, 2021 20:07
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 28, 2021
@@ -111,7 +109,6 @@
* </code>
* </pre>
*/
@Generated("by GAPIC v0.0.5")
@BetaApi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it still Beta?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed for this and OperationSettings. I left them in for the stub classes (since they're everywhere across the dependent APIs), but LMK if we should remove them in one fell swoop.

@elharo
Copy link
Contributor

elharo commented Jan 28, 2021

The following files are not formatted properly:

FAILURE: Build failed with an exception.

  • What went wrong:
    Execution failed for task ':verifyGoogleJavaFormat'.

Problems: formatting style violations

  • Try:

@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

Merging #1282 (b73ab36) into master (95a7dab) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1282   +/-   ##
=========================================
  Coverage     79.19%   79.19%           
  Complexity     1235     1235           
=========================================
  Files           209      209           
  Lines          5378     5378           
  Branches        454      454           
=========================================
  Hits           4259     4259           
  Misses          939      939           
  Partials        180      180           
Impacted Files Coverage Δ Complexity Δ
.../java/com/google/longrunning/OperationsClient.java 73.33% <ø> (ø) 16.00 <0.00> (ø)
...ava/com/google/longrunning/OperationsSettings.java 29.03% <ø> (ø) 2.00 <0.00> (ø)
...ongrunning/stub/GrpcOperationsCallableFactory.java 37.50% <ø> (ø) 3.00 <0.00> (ø)
...om/google/longrunning/stub/GrpcOperationsStub.java 89.65% <ø> (ø) 11.00 <0.00> (ø)
...va/com/google/longrunning/stub/OperationsStub.java 16.66% <ø> (ø) 1.00 <0.00> (ø)
...oogle/longrunning/stub/OperationsStubSettings.java 73.83% <ø> (ø) 8.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95a7dab...cce6fda. Read the comment docs.

@miraleung
Copy link
Contributor Author

The following files are not formatted properly:

FAILURE: Build failed with an exception.

  • What went wrong:
    Execution failed for task ':verifyGoogleJavaFormat'.

Problems: formatting style violations

  • Try:

Done.

@miraleung miraleung changed the title fix(operations): Make Operations a manual client fix(operations): Make Operations a manual client [gax-java] Jan 28, 2021
@miraleung miraleung merged commit 5be66cd into master Feb 2, 2021
@miraleung miraleung deleted the fix/operations_client branch February 2, 2021 19:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants