This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
fix: prevent npe caused by missing parentheses #1198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1198 +/- ##
=========================================
Coverage ? 79.18%
Complexity ? 1199
=========================================
Files ? 205
Lines ? 5270
Branches ? 436
=========================================
Hits ? 4173
Misses ? 924
Partials ? 173
Continue to review full report at Codecov.
|
elharo
reviewed
Oct 5, 2020
|
@elharo Hey, thank you for your feedback! I can create an issue for this PR in a bit. For the tests: Unfortunately I don't understand what is going on in this class (and what it is for) so it would cost me several hours to set up a working test case for it (AFAICT there aren't any tests for this class yet). I think that would not be worth it. What do you think? |
elharo
reviewed
Oct 5, 2020
miraleung
approved these changes
Oct 5, 2020
Gerschtli
force-pushed
the
fix-npe
branch
2 times, most recently
from
b1390bc
to
af11f2d
Compare
|
Created an issue and a basic minimal test case for my fix. PTAL |
elharo
approved these changes
Oct 12, 2020
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Oct 19, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [1.60.0](https://www.github.com/googleapis/gax-java/compare/v1.59.1...v1.60.0) (2020-10-19) ### Features * REST Gapic (REGAPIC) Support ([#1177](https://www.github.com/googleapis/gax-java/issues/1177)) ([12b18ee](https://www.github.com/googleapis/gax-java/commit/12b18ee255d3fabe13bb3969df40753b29f830d5)) ### Bug Fixes * prevent npe caused by missing parentheses ([#1198](https://www.github.com/googleapis/gax-java/issues/1198)) ([b856351](https://www.github.com/googleapis/gax-java/commit/b85635123f987f9808086f14a58dd8c7418a3bd8)) ### Dependencies * upgrade grpc to 1.32.2 ([#1212](https://www.github.com/googleapis/gax-java/issues/1212)) ([03c4c0f](https://www.github.com/googleapis/gax-java/commit/03c4c0f621f439c30752122568d2a9a7703e5e16)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently I can't set the log level lower than
FINERbecause this library throws a NPE. The cause of this problem is a missing pair of parentheses.This is the current snippet:
Which is equivalent to:
This results in calling
callable.getClass().getEnclosingMethod().getName()even ifcallable.getClass().getEnclosingMethod()isnull.Fixes #1198.