This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
feat: Allow user-agents to be specified by both internal headers and user headers #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…user headers This is primarily meant to address the googleapis/java-bigtable#404 (review). Where both the hbase adapter and the core client needs to set the UserAgent. To reconcile the conflict this PR takes grpc's approach and concatenates the values. The reason this needs to happen now is that for DirectPath we need to ship clients that send a UserAgent, however Bigtable needs to keep stats to differentiate client usage.
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1190 +/- ##
=========================================
Coverage 58.91% 58.91%
Complexity 115 115
=========================================
Files 20 20
Lines 589 589
Branches 60 60
=========================================
Hits 347 347
Misses 213 213
Partials 29 29 Continue to review full report at Codecov.
|
elharo
suggested changes
Sep 23, 2020
elharo
approved these changes
Sep 23, 2020
igorbernstein2
added
kokoro:force-run
|
I think kokoro is broken? |
|
Thanks Igor for making this change! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is primarily meant to address the googleapis/java-bigtable#404 (review). Where both the hbase adapter and the core client needs to set the UserAgent. To reconcile the conflict this PR takes grpc's approach and concatenates the values. The reason this needs to happen now is that for DirectPath we need to ship clients that send a UserAgent, however Bigtable needs to keep stats to differentiate client usage.