This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
fix: fix dependencies.properties resource file creation during deployment #1163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
… and include in sources
Codecov Report
@@ Coverage Diff @@
## master #1163 +/- ##
=========================================
Coverage 78.97% 78.97%
Complexity 1194 1194
=========================================
Files 205 205
Lines 5266 5266
Branches 436 436
=========================================
Hits 4159 4159
Misses 935 935
Partials 172 172 Continue to review full report at Codecov.
|
chingor13
changed the title
chingor13
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the dependencies.properties file to be created into the build/generated-resources directory and includes that directory as part of the sources set.
This should fix the generation version detection.
Verified by running
git clean -fdx && ./gradlew publishToMavenLocal. The tests pass during the publish and built jar in the local repo includes the dependencies.properties file.Fixes #1164