This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
feat: add retry logging #1160
Merged
feat: add retry logging #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1160 +/- ##
============================================
- Coverage 79.07% 78.97% -0.11%
- Complexity 1193 1194 +1
============================================
Files 205 205
Lines 5258 5266 +8
Branches 433 436 +3
============================================
+ Hits 4158 4159 +1
- Misses 929 935 +6
- Partials 171 172 +1
Continue to review full report at Codecov.
|
pmakani
approved these changes
Jul 31, 2020
vam-google
reviewed
Jul 31, 2020
gax/src/main/java/com/google/api/gax/retrying/BasicRetryingFuture.java
Outdated
Show resolved
Hide resolved
igorbernstein2
previously requested changes
Jul 31, 2020
There was a problem hiding this comment.
I dont think this is a good idea.
Logging should be reserved for unexpected errors and for things that callers can do something about. Retries should be considered part of normal operation. I think this will increase support load for service teams unnecessarily.
Can we discuss this offline before merging this?
vam-google
approved these changes
Jul 31, 2020
gax/src/main/java/com/google/api/gax/retrying/BasicRetryingFuture.java
Outdated
Show resolved
Hide resolved
igorbernstein2
dismissed
their stale review
Spoke offline and this seems like the best option in the short term future
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes b/160995457