Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

Conversation

rgrebski
Copy link
Contributor

Fixes #870 , see my comment

@google-cla
Copy link

google-cla bot commented Jul 28, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Jul 28, 2020
@rgrebski
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jul 28, 2020
@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #1158 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1158      +/-   ##
============================================
- Coverage     79.07%   79.07%   -0.01%     
  Complexity     1193     1193              
============================================
  Files           205      205              
  Lines          5258     5257       -1     
  Branches        433      433              
============================================
- Hits           4158     4157       -1     
  Misses          929      929              
  Partials        171      171              
Impacted Files Coverage Δ Complexity Δ
...src/main/java/com/google/api/gax/rpc/Watchdog.java 79.50% <ø> (-0.17%) 12.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7646a3...d27f9d6. Read the comment docs.

Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
Thanks!

@rgrebski rgrebski changed the title [Issue-870] Watchdog.shutdownNow() does not shutdown executor now [Issue-870] Watchdog.shutdownNow() does not shutdown executor Jul 29, 2020
@rgrebski rgrebski changed the title [Issue-870] Watchdog.shutdownNow() does not shutdown executor [Issue-#870] Watchdog.shutdownNow() does not shutdown executor Jul 29, 2020
@rgrebski rgrebski changed the title [Issue-#870] Watchdog.shutdownNow() does not shutdown executor [Issue-870] Watchdog.shutdownNow() does not shutdown executor Jul 29, 2020
@chingor13 chingor13 changed the title [Issue-870] Watchdog.shutdownNow() does not shutdown executor fix: Watchdog.shutdownNow() does not shutdown executor Aug 6, 2020
@chingor13 chingor13 merged commit 6241a21 into googleapis:master Aug 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WatchDog shuts down ExecutorService from FixedExecutorProvider
3 participants