From 2cca0bf9e96271dd52e8bffa00b8f2d45d358d35 Mon Sep 17 00:00:00 2001 From: Vadym Matsishevskyi <25311427+vam-google@users.noreply.github.com> Date: Mon, 3 May 2021 14:00:29 -0700 Subject: [PATCH] fix: Remove a flacky test in FlowControllerTest (#1360) It is a temporary workaround. More details here: https://github.com/googleapis/gax-java/issues/1359 --- .../java/com/google/api/gax/batching/FlowControllerTest.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gax/src/test/java/com/google/api/gax/batching/FlowControllerTest.java b/gax/src/test/java/com/google/api/gax/batching/FlowControllerTest.java index b0bc72531..57e60b094 100644 --- a/gax/src/test/java/com/google/api/gax/batching/FlowControllerTest.java +++ b/gax/src/test/java/com/google/api/gax/batching/FlowControllerTest.java @@ -50,6 +50,7 @@ import java.util.concurrent.TimeUnit; import java.util.concurrent.TimeoutException; import java.util.concurrent.atomic.AtomicInteger; +import org.junit.Ignore; import org.junit.Test; import org.junit.runner.RunWith; import org.junit.runners.JUnit4; @@ -538,6 +539,9 @@ public void testConcurrentUpdateThresholds_blocking() throws Exception { testBlockingReserveRelease(flowController, 0, expectedValue); } + // This test is very flaky. Remove @Ignore once https://github.com/googleapis/gax-java/issues/1359 + // is fixed. + @Ignore @Test public void testConcurrentUpdateThresholds_nonBlocking() throws Exception { int initialValue = 5000;