Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow invoke to preserve call & context errors for retry until timeout #158

Closed
tritone opened this issue Dec 16, 2021 · 1 comment
Closed

Allow invoke to preserve call & context errors for retry until timeout #158

tritone opened this issue Dec 16, 2021 · 1 comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@tritone
Copy link

tritone commented Dec 16, 2021

Currently if Invoke is called and the request is retried until a timeout, it will return a context error only. The underlying error from the service will be lost.

We can use error wrapping to preserve both errors. See googleapis/google-cloud-go#4797 for an example.
@tritone tritone added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Dec 16, 2021
@codyoss
Copy link
Member

codyoss commented Dec 21, 2022

Closing as a dupe of #235

@codyoss codyoss closed this as completed Dec 21, 2022
@codyoss codyoss reopened this Dec 21, 2022
@codyoss codyoss closed this as not planned Won't fix, can't repro, duplicate, stale Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tritone @codyoss