Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit the AST Class to allow to add a ; on command. #697

Open
Hectorhammett opened this issue Mar 26, 2024 · 1 comment
Open

Edit the AST Class to allow to add a ; on command. #697

Hectorhammett opened this issue Mar 26, 2024 · 1 comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@Hectorhammett
Copy link
Contributor

We currently cannot create resources with the ResourcesGenerator without appending a ; to the toCode method as if we remove the appended semicolon it ends up generating "invalid" code as it is missing the last semicolon.

In this specific case we are using a PhpFile class which inherits from AST. So there is a bit of hoops that we might need to work on in order to make be able to add a semi colon to our files when we need them.
@Hectorhammett Hectorhammett added type: cleanup An internal cleanup or hygiene concern. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Mar 26, 2024
@noahdietz
Copy link
Collaborator

relevant discussion: #696 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@noahdietz @Hectorhammett