Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 post-processing step leaves "fragments" directories #621

Open
bshaffer opened this issue May 2, 2023 · 2 comments
Open

V2 post-processing step leaves "fragments" directories #621

bshaffer opened this issue May 2, 2023 · 2 comments
Labels
good first issue This issue is a good place to started contributing to this repository. priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@bshaffer
Copy link
Contributor

bshaffer commented May 2, 2023

This is of course very low priority, as it does not cause any issues AFAIK, but when untar-ing the resulting package from the GAPIC post-processor, I can see that the fragment directories are there even though they contain no files (and we don't want them there):

$ bazel build google/cloud/support/v2:google-cloud-support-v2-php
$ tar -xvf bazel-bin/google/cloud/support/v2/google-cloud-support-v2-php.tar.gz
google-cloud-support-v2-php/fragments/
google-cloud-support-v2-php/fragments/Google/
google-cloud-support-v2-php/fragments/Google/Cloud/
google-cloud-support-v2-php/fragments/Google/Cloud/Support/
google-cloud-support-v2-php/fragments/Google/Cloud/Support/V2/
google-cloud-support-v2-php/proto/
...

We should remove the empty directories in the post processing step to reduce the noise

@bshaffer bshaffer added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels May 2, 2023
@noahdietz
Copy link
Collaborator

The fragment files are excluded here, but the directories aren't removed. Tricky! Thanks, should be excluded for sure. Does this block generation? Is owlbot able to ignore those?

@bshaffer
Copy link
Contributor Author

bshaffer commented May 2, 2023

Owlbot does not move these over, and even if they did, git doesn't track empty directories, so this doesn't block anything

@noahdietz noahdietz added good first issue This issue is a good place to started contributing to this repository. priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue This issue is a good place to started contributing to this repository. priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants