Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snippet gen feature request: add UpdateMask to update samples #558

Open
bshaffer opened this issue Jan 6, 2023 · 0 comments
Open

snippet gen feature request: add UpdateMask to update samples #558

bshaffer opened this issue Jan 6, 2023 · 0 comments
Labels
good first issue This issue is a good place to started contributing to this repository. priority: p3 Desirable enhancement or fix. May not be included in next release. samples Issues that are directly related to samples. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@bshaffer
Copy link
Contributor

bshaffer commented Jan 6, 2023

Many of the update RPC methods require a FieldMask in order to have an effect. This is conveyed in the samples like VideoStitcherServiceClient::updateCdnKey where the parameter is required, but in other RPCs such as LivestreamServiceClient::updateInput, it's not obvious to the user that this is required. And the effect of not knowing this is that the RPC call has no effect (no fields are updated), even though the request is successful.

When the updateMask parameter is marked optional, it would be more useful if we included creating the updateMask as part of the sample.

This may be addressed once we release support in PHP for method_signature annotations (see https://google.aip.dev/134)

@bshaffer bshaffer added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Jan 6, 2023
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 6, 2023
@noahdietz noahdietz added the good first issue This issue is a good place to started contributing to this repository. label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue This issue is a good place to started contributing to this repository. priority: p3 Desirable enhancement or fix. May not be included in next release. samples Issues that are directly related to samples. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

2 participants