Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2 feature request: Use strict types for new client classes #555

Open
bshaffer opened this issue Dec 21, 2022 · 0 comments
Open

V2 feature request: Use strict types for new client classes #555

bshaffer opened this issue Dec 21, 2022 · 0 comments
Assignees
@bshaffer
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. v2 Issues and features set to release with the gapic generator v2

Comments

@bshaffer
Copy link
Contributor

bshaffer commented Dec 21, 2022 •
edited

We should add "strict"types" to the new Client and BaseClient classes (and to any other net-new V2 classes).

declare(strict_types=1);

See https://dev.to/rocksheep/the-way-stricttypes-works-in-php-eb7

Note: this feature was added in PHP 7.0, so we would only be able to add this after we drop support for PHP 5.6
@bshaffer bshaffer added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. v2 Issues and features set to release with the gapic generator v2 labels Dec 21, 2022
@bshaffer bshaffer self-assigned this Jun 6, 2023
@bshaffer bshaffer added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. and removed priority: p3 Desirable enhancement or fix. May not be included in next release. labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bshaffer bshaffer

Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. v2 Issues and features set to release with the gapic generator v2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bshaffer