Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support experimental boolean flag for all generated surfaces #534

Open
noahdietz opened this issue Nov 15, 2022 · 1 comment
Open

Support experimental boolean flag for all generated surfaces #534

noahdietz opened this issue Nov 15, 2022 · 1 comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@noahdietz
Copy link
Collaborator

Sometimes an API launches a public preview in a stable API version and wants to indicate that the surface is still "experimental", until the service reaches the GA/Stable marker. Currently, the generator will only mark GAPIC surfaces as @experimental is the proto package being generated contains alpha or beta.

We need an experimental generator flag (in the bazel rule too) that allows us to toggle on generation of the @experimental annotation regardless of the proto package.

@noahdietz noahdietz added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Nov 15, 2022
@noahdietz
Copy link
Collaborator Author

We currently determine if the @experimental flag should be added here.

This functionality should be retained, but also extended to consult a new experimental boolean flag. Other examples of adding flags to the generator stack include these: #497 and #530

@saranshdhingra this would be a great starter task :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

1 participant