Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bazel): ensure integration tests diff files recursively [ggj] #745

Merged
merged 3 commits into from Jun 2, 2021
Merged

fix(bazel): ensure integration tests diff files recursively [ggj] #745

merged 3 commits into from Jun 2, 2021

Conversation

miraleung
Copy link
Contributor

Take two on #744 so we can merge this into the main branch after #743.

@miraleung miraleung requested a review from a team as a code owner June 1, 2021 20:28
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 1, 2021
@miraleung miraleung requested a review from vam-google June 1, 2021 20:28
@codecov
Copy link

codecov bot commented Jun 1, 2021 •
edited

Codecov Report

Merging #745 (1483773) into master (8f6f40e) will increase coverage by 0.00%.
The diff coverage is 96.00%.

❗ Current head 1483773 differs from pull request most recent head 3cffa4d. Consider uploading reports for the commit 3cffa4d to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #745   +/-   ##
=======================================
  Coverage   91.42%   91.43%           
=======================================
  Files         133      133           
  Lines       13861    13874   +13     
  Branches     1031     1031           
=======================================
+ Hits        12673    12686   +13     
  Misses        907      907           
  Partials      281      281
Impacted Files Coverage Δ
.../composer/grpc/ServiceClientTestClassComposer.java 93.56% <50.00%> (ø)
...common/AbstractServiceClientTestClassComposer.java 87.96% <100.00%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdb705b...3cffa4d. Read the comment docs.

Base automatically changed from fix/test_field_order to master June 2, 2021 13:23
@miraleung
Copy link
Contributor Author

Merging this is the same as #744.

@miraleung miraleung merged commit ddc75f9 into master Jun 2, 2021
@miraleung miraleung deleted the fix/bazel_tests branch June 2, 2021 13:24
suztomo pushed a commit that referenced this pull request Mar 21, 2023
@renovate-bot
chore(deps): update dependency com.google.cloud:google-cloud-shared-d…
86135cb 
…ependencies to v2 (#745)
suztomo pushed a commit that referenced this pull request Mar 21, 2023
@gcf-owl-bot
chore: update github actions (#1361) (#745)
83b5313 
* chore: update github actions

* chore: update
Source-Link: googleapis/synthtool@1622741
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:e3746f84955528d0fe24bf2e4df89875d6ce5a036af01b9c326d61a38838523a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vam-google vam-google Awaiting requested review from vam-google

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@miraleung