Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support enums in proto HTTP annotations [ggj] #733

Merged
merged 1 commit into from May 24, 2021

Conversation

miraleung
Copy link
Contributor

No description provided.

@miraleung miraleung requested a review from a team as a code owner May 24, 2021 20:05
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 24, 2021
@miraleung miraleung requested a review from vam-google May 24, 2021 20:05
@codecov
Copy link

codecov bot commented May 24, 2021

Codecov Report

Merging #733 (dc155c8) into master (f44df21) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #733      +/-   ##
==========================================
- Coverage   92.04%   92.04%   -0.01%     
==========================================
  Files         124      124              
  Lines       13531    13531              
  Branches     1005     1006       +1     
==========================================
- Hits        12455    12454       -1     
  Misses        823      823              
- Partials      253      254       +1     
Impacted Files Coverage Δ
...pi/generator/gapic/protoparser/HttpRuleParser.java 85.71% <0.00%> (-1.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f44df21...dc155c8. Read the comment docs.

Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Can we also add a test for it? Only if it can be done with little effort, please do not add the full set of new test just for this feature (really not worth it).

@miraleung miraleung merged commit f5c7b86 into master May 24, 2021
@miraleung miraleung deleted the miraleung-patch-1 branch May 24, 2021 23:39
@miraleung
Copy link
Contributor Author

LGTM.
Can we also add a test for it? Only if it can be done with little effort, please do not add the full set of new test just for this feature (really not worth it).

Clicked merge too soon, will look into this as a followup.

suztomo pushed a commit that referenced this pull request Mar 21, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
suztomo pushed a commit that referenced this pull request Mar 21, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants