Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mixins): Gate mixin RPC on HTTP rules, add yaml doc/http overrides [ggj] #727

Merged
merged 2 commits into from May 19, 2021

Conversation

miraleung
Copy link
Contributor

No description provided.

@miraleung miraleung requested a review from a team as a code owner May 18, 2021 23:45
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 18, 2021
@miraleung miraleung changed the title fix(mixins): Gate mixin RPC on HTTP rules, override w/ yaml doc/http rules [ggj] fix(mixins): Gate mixin RPC on HTTP rules, add yaml doc/http overrides [ggj] May 18, 2021
@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #727 (a156256) into master (83e2e3b) will decrease coverage by 0.25%.
The diff coverage is 14.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #727      +/-   ##
==========================================
- Coverage   92.30%   92.04%   -0.26%     
==========================================
  Files         124      124              
  Lines       13491    13531      +40     
  Branches      996     1005       +9     
==========================================
+ Hits        12453    12455       +2     
- Misses        786      823      +37     
- Partials      252      253       +1     
Impacted Files Coverage Δ
...google/api/generator/gapic/protoparser/Parser.java 44.68% <0.00%> (-3.38%) ⬇️
...pi/generator/gapic/protoparser/HttpRuleParser.java 87.14% <72.72%> (-3.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83e2e3b...a156256. Read the comment docs.

Copy link
Contributor

@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks Mira

@miraleung miraleung merged commit 229da5d into master May 19, 2021
@miraleung miraleung deleted the dev/mixins branch May 19, 2021 22:05
suztomo pushed a commit that referenced this pull request Mar 21, 2023
Source-Link: googleapis/synthtool@7a220e2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28
suztomo pushed a commit that referenced this pull request Mar 21, 2023
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.code.gson:gson](https://togithub.com/google/gson) | `2.8.9` -> `2.9.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.code.gson:gson/2.9.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.code.gson:gson/2.9.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.code.gson:gson/2.9.0/compatibility-slim/2.8.9)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.code.gson:gson/2.9.0/confidence-slim/2.8.9)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>google/gson</summary>

### [`v2.9.0`](https://togithub.com/google/gson/blob/HEAD/CHANGELOG.md#Version-290)

**The minimum supported Java version changes from 6 to 7.**

-   Change target Java version to 7 ([#&#8203;2043](https://togithub.com/google/gson/issues/2043))
-   Put `module-info.class` into Multi-Release JAR folder ([#&#8203;2013](https://togithub.com/google/gson/issues/2013))
-   Improve error message when abstract class cannot be constructed ([#&#8203;1814](https://togithub.com/google/gson/issues/1814))
-   Support EnumMap deserialization ([#&#8203;2071](https://togithub.com/google/gson/issues/2071))
-   Add LazilyParsedNumber default adapter ([#&#8203;2060](https://togithub.com/google/gson/issues/2060))
-   Fix JsonReader.hasNext() returning true at end of document ([#&#8203;2061](https://togithub.com/google/gson/issues/2061))
-   Remove Gradle build support. Build script was outdated and not actively
    maintained anymore ([#&#8203;2063](https://togithub.com/google/gson/issues/2063))
-   Add `GsonBuilder.disableJdkUnsafe()` ([#&#8203;1904](https://togithub.com/google/gson/issues/1904))
-   Add `UPPER_CASE_WITH_UNDERSCORES` in FieldNamingPolicy ([#&#8203;2024](https://togithub.com/google/gson/issues/2024))
-   Fix failing to serialize Collection or Map with inaccessible constructor ([#&#8203;1902](https://togithub.com/google/gson/issues/1902))
-   Improve TreeTypeAdapter thread-safety ([#&#8203;1976](https://togithub.com/google/gson/issues/1976))
-   Fix `Gson.newJsonWriter` ignoring lenient and HTML-safe setting ([#&#8203;1989](https://togithub.com/google/gson/issues/1989))
-   Delete unused LinkedHashTreeMap ([#&#8203;1992](https://togithub.com/google/gson/issues/1992))
-   Make default adapters stricter; improve exception messages ([#&#8203;2000](https://togithub.com/google/gson/issues/2000))
-   Fix `FieldNamingPolicy.upperCaseFirstLetter` uppercasing non-letter ([#&#8203;2004](https://togithub.com/google/gson/issues/2004))

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants