Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Poison 5.0 and/or other JSON decoders/encoders? #8372

Open
michallepicki opened this issue Aug 23, 2021 · 1 comment
Open
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@michallepicki
Copy link

Currently the google_gax project depends on poison >= 3.0.0 and < 5.0.0. This means that we cannot use Poison 5.0 without overriding the version.

plug(Tesla.Middleware.EncodeJson, engine: Poison)

Would it be possible to check if poison 5.0 causes problems, and if not, loosen the version requirement to allow Poison 5.0?

Alternatively, would it be possible to remove this dependency (or mark as optional) and allow the user to configure a different JSON decoder/encoder, like e.g. Jason? Tesla is configurable so it should be rather easy. In fact I think some of the clients already use Jason because it's the default in Tesla, e.g. here:

@michallepicki michallepicki added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Aug 23, 2021
@michallepicki michallepicki changed the title Compatibility with Poison 5.0 and/or other JSON encoders? Compatibility with Poison 5.0 and/or other JSON decoders/encoders? Aug 23, 2021
@esambo
Copy link

esambo commented Feb 1, 2023

FYI, see the related #8251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

2 participants