Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialogflow: Other availibility zones #6574

Open
arjan opened this issue Oct 21, 2020 · 1 comment
Open

Dialogflow: Other availibility zones #6574

arjan opened this issue Oct 21, 2020 · 1 comment
Assignees
Labels
api: dialogflow Issues related to the Dialogflow API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@arjan
Copy link

arjan commented Oct 21, 2020

Dialogflow (ES) supports multiple availability zones now.
The current generated client is not capable of handling this, as the base URL is hardcoded in the generated Connection module. What would be a solution for this?

If I would program it manually i would add a zone to the opts passed into each function, and from the zone opt the proper Connection would be selected.

So there would exist several different Connection modules, one for each zone, basically four modules:

image

@product-auto-label product-auto-label bot added the api: dialogflow Issues related to the Dialogflow API. label Oct 21, 2020
@arjan
Copy link
Author

arjan commented Oct 21, 2020

Current solution is here: botsquad/google_api_dialogflow_fork@1d55a32

Created a new/2 function:

conn = Connection.new("token", zone: "europe-west2")

Let me know if I should create a PR for the Elixir generator.

@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Oct 22, 2020
@dazuma dazuma added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: dialogflow Issues related to the Dialogflow API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

4 participants