feat: regenerate #151

busunkim96 · 2019-10-10T00:24:10Z

v2 and v2beta1

Add set_agent and delete_agent methods to AgentsClient
Add api_version and tier to Agents
Add session_entity_types to WebhookResponse
Add model_variant and single_utterance to InputAudioConfig
Add SpeechModelVariant enum
Add enable_fuzzy_extraction to EntityType
Add KIND_REGEXP to EntityType.Kind enum
Add client_options to clients
Allow kwargs to be passed to transport create_channel methods
Deprecate single_utterance attribute in StreamingDetectIntentRequest. Please use InputAudioConfig.single_utterance

v2

Add Google Hangouts to Message.Platform enum

v2beta1

Add get_validation_result method to AgentsClient
Add gcs_source and source to reload_document method in DocumentsClient
Add Rich Business Messaging (RBM) support, table_card, and media_content to intent messages
Add enable_word_info, speech_contexts to InputAudioConfig
update_document returns _OperationFuture rather than Operation
Deprecate projects.agent.knowledgeBases. Please use projects.knowledgeBases.
Add stability, speech_word_info and speech_end_offset to StreamingRecognitionResult

busunkim96

These are notes I took for myself as I went through the diff.

busunkim96 · 2019-10-10T21:22:30Z

tests/unit/gapic/v2beta1/test_knowledge_bases_client_v2beta1.py

+        # Setup Request
+        knowledge_base = {}
+
+        response = client.update_knowledge_base(knowledge_base)


Passes empty knowledge_base in UpdateKnowledgeBaseRequest.

busunkim96 · 2019-10-10T21:24:06Z

tests/unit/gapic/v2beta1/test_entity_types_client_v2beta1.py

@@ -118,11 +112,12 @@ def test_get_entity_type(self):
        # Setup Expected Response
        name_2 = 'name2-1052831874'
        display_name = 'displayName1615086568'
-        expected_response = {'name': name_2, 'display_name': display_name}
+        enable_fuzzy_extraction = True


Add enable_fuzzy_extraction

busunkim96 · 2019-10-11T19:16:53Z

dialogflow_v2/gapic/agents_client.py

 """Accesses the google.cloud.dialogflow.v2 Agents API."""

 import functools
 import pkg_resources
 import warnings

 from google.oauth2 import service_account
+import google.api_core.client_options


Add client_options to v2

So client_options are basically a way to set the endpoint directly?

busunkim96 · 2019-10-11T19:18:01Z

dialogflow_v2/gapic/agents_client.py

-                  retry=google.api_core.gapic_v1.method.DEFAULT,
-                  timeout=google.api_core.gapic_v1.method.DEFAULT,
-                  metadata=None):
+    def set_agent(


Add set_agent and delete_agent to v2.

busunkim96 · 2019-10-11T19:22:17Z

dialogflow_v2/gapic/enums.py

@@ -111,6 +112,50 @@ class OutputAudioEncoding(enum.IntEnum):
    OUTPUT_AUDIO_ENCODING_OGG_OPUS = 3


+class SpeechModelVariant(enum.IntEnum):


Add SpeechModelVariant enum to v2

busunkim96 · 2019-10-11T19:42:11Z

dialogflow_v2beta1/proto/audio_config_pb2.py

          language.
+      enable_word_info:


Add enable_word_info, speech_contexts, model_variant, single_utterance to InputAudioConfig (v2beta1)

busunkim96 · 2019-10-11T19:43:19Z

dialogflow_v2beta1/proto/gcs_pb2.py

+          is of the form: gs://bucket/object-prefix-or-name Whether a
+          prefix or name is used depends on the use case.
+  """,
+  # @@protoc_insertion_point(class_scope:google.cloud.dialogflow.v2beta1.GcsSource)


Add GcsSource to v2beta1

busunkim96 · 2019-10-11T19:44:33Z

dialogflow_v2beta1/proto/intent_pb2.py

@@ -2575,6 +3204,266 @@
      # @@protoc_insertion_point(class_scope:google.cloud.dialogflow.v2beta1.Intent.Message.TelephonyTransferCall)
      ))
    ,
+


Add Rich Business Messaging support to intent message (v2beta1)

busunkim96 · 2019-10-11T19:45:25Z

dialogflow_v2beta1/proto/intent_pb2.py

@@ -2615,6 +3504,14 @@
            Synthesizes speech in Telephony Gateway.
        telephony_transfer_call:
            Transfers the call in Telephony Gateway.
+        rbm_text:


Add rbm_text, rbm_standalone_rich_card, rbm_standalone_rich_card to Intent.Message (v2beta1)

busunkim96 · 2019-10-11T19:46:31Z

dialogflow_v2beta1/proto/validation_result_pb2.py

+      error_message:
+          The detailed error messsage.
+  """,
+  # @@protoc_insertion_point(class_scope:google.cloud.dialogflow.v2beta1.ValidationError)


Add ValidationError, ValidationResult to v2beta1

busunkim96 · 2019-10-11T20:26:37Z

dialogflow_v2/proto/session_pb2.py

@@ -1218,8 +1135,10 @@
          form of text, or  3. an event that specifies which intent to
          trigger.
      single_utterance:
-          Optional. If ``false`` (default), recognition does not cease
-          until the client closes the stream. If ``true``, the
+          DEPRECATED. Please use [InputAudioConfig.single\_utterance][go


Deprecate single_utterance in StreamingDetectIntentrequest

busunkim96 · 2019-10-15T19:35:22Z

@nnegrey Please review/merge when you are ready.

busunkim96 · 2019-10-11T21:28:03Z

dialogflow_v2/proto/webhook_pb2.py

+          input. When this field is set, Dialogflow ignores the
+          ``fulfillment_text``, ``fulfillment_messages``, and
+          ``payload`` fields.
+      session_entity_types:


Add session_entity_types to WebhookResponse

busunkim96 · 2019-10-11T21:30:25Z

dialogflow_v2beta1/proto/session_pb2.py

@@ -1488,6 +1545,24 @@
          was not set.  This field is typically only provided if
          ``is_final`` is true and you should not rely on it being
          accurate or even set.
+      stability:


Add stability, speech_word_info and speech_end_offset to StreamingRecognitionResult

busunkim96 · 2019-10-11T21:34:19Z

dialogflow_v2beta1/proto/entity_type_pb2.py

@@ -821,6 +834,9 @@
      entities:
          Optional. The collection of entity entries associated with the
          entity type.
+      enable_fuzzy_extraction:


Add enable_fuzzy_extraction to EntityType

nnegrey · 2019-10-16T14:37:27Z

dialogflow_v2/proto/agent.proto

-
-syntax = "proto3";
-
-package google.cloud.dialogflow.v2;


Removing .proto files, because they exist in googleapis, yes?

nnegrey

LGTM

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 10, 2019

busunkim96 commented Oct 11, 2019

View reviewed changes

busunkim96 requested a review from nnegrey October 11, 2019 20:53

busunkim96 force-pushed the fix-synth branch from 5736f59 to 7ccdff4 Compare October 11, 2019 20:55

busunkim96 added 4 commits October 14, 2019 13:28

build: fix synth

76910b1

fix: more _pb2 modifications

c21e649

docs: fix docstring in intent_pb2

e96cde3

chore: blacken new additions

64a9ae8

busunkim96 force-pushed the fix-synth branch from 7151d56 to 64a9ae8 Compare October 14, 2019 20:30

busunkim96 added 2 commits October 15, 2019 11:31

fix: resynth to get lost changes

8ac5e46

chore: blacken tests directory

99bcbe9

busunkim96 commented Oct 15, 2019

View reviewed changes

nnegrey reviewed Oct 16, 2019

View reviewed changes

nnegrey approved these changes Oct 16, 2019

View reviewed changes

nnegrey merged commit 6222277 into master Oct 16, 2019

busunkim96 deleted the fix-synth branch October 17, 2019 16:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: regenerate #151

feat: regenerate #151

busunkim96 commented Oct 10, 2019 •

edited

busunkim96 left a comment •

edited

busunkim96 Oct 10, 2019

busunkim96 Oct 10, 2019

busunkim96 Oct 11, 2019

nnegrey Oct 16, 2019

busunkim96 Oct 11, 2019

busunkim96 Oct 11, 2019

busunkim96 Oct 11, 2019

busunkim96 Oct 11, 2019

busunkim96 Oct 11, 2019

busunkim96 Oct 11, 2019

busunkim96 Oct 11, 2019

busunkim96 Oct 11, 2019

busunkim96 commented Oct 15, 2019

busunkim96 Oct 11, 2019

busunkim96 Oct 11, 2019

busunkim96 Oct 11, 2019

nnegrey Oct 16, 2019 •

edited

nnegrey left a comment

		@@ -111,6 +112,50 @@ class OutputAudioEncoding(enum.IntEnum):
		OUTPUT_AUDIO_ENCODING_OGG_OPUS = 3


		class SpeechModelVariant(enum.IntEnum):


		syntax = "proto3";

		package google.cloud.dialogflow.v2;

feat: regenerate #151

feat: regenerate #151

Conversation

busunkim96 commented Oct 10, 2019 • edited

v2 and v2beta1

v2

v2beta1

busunkim96 left a comment • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

busunkim96 commented Oct 15, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nnegrey Oct 16, 2019 • edited

Choose a reason for hiding this comment

nnegrey left a comment

Choose a reason for hiding this comment

busunkim96 commented Oct 10, 2019 •

edited

busunkim96 left a comment •

edited

nnegrey Oct 16, 2019 •

edited