Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(logging): allow pino to be configured #97

Merged
merged 3 commits into from Sep 4, 2020
Merged

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Sep 4, 2020

Allow pino to be configured with an options object, rather than requiring that upstream libraries pass in an instantiated logger instance.

@bcoe bcoe requested a review from a team September 4, 2020 17:23
@bcoe bcoe requested a review from a team as a code owner September 4, 2020 17:23
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 4, 2020
@codecov
Copy link

codecov bot commented Sep 4, 2020

Codecov Report

Merging #97 into master will decrease coverage by 0.19%.
The diff coverage is 62.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
- Coverage   85.88%   85.69%   -0.20%     
==========================================
  Files          14       14              
  Lines        1240     1244       +4     
  Branches       83       91       +8     
==========================================
+ Hits         1065     1066       +1     
- Misses        174      177       +3     
  Partials        1        1              
Impacted Files Coverage Δ
src/logger/index.ts 88.88% <50.00%> (-11.12%) ⬇️
src/index.ts 99.38% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8df9310...a348bfb. Read the comment docs.

@bcoe bcoe merged commit d45e474 into master Sep 4, 2020
@bcoe bcoe deleted the easy-logger-configure branch September 4, 2020 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants