Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: return the PR created #95

Merged
merged 6 commits into from Sep 2, 2020
Merged

feat: return the PR created #95

merged 6 commits into from Sep 2, 2020

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Sep 2, 2020

This allows upstream users of code-suggester to take action based on the PR number created.

release-please uses this when identifying PRs that should be closed.

@bcoe bcoe requested a review from a team September 2, 2020 04:32
@bcoe bcoe requested a review from a team as a code owner September 2, 2020 04:32
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 2, 2020
@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #95 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
+ Coverage   85.86%   85.87%   +0.01%     
==========================================
  Files          14       14              
  Lines        1238     1239       +1     
  Branches       87       89       +2     
==========================================
+ Hits         1063     1064       +1     
  Misses        174      174              
  Partials        1        1              
Impacted Files Coverage Δ
src/github-handler/pull-request-handler.ts 100.00% <100.00%> (ø)
src/index.ts 99.38% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9579bae...6ad6be3. Read the comment docs.

src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
bcoe and others added 3 commits September 2, 2020 13:17
Co-authored-by: Tyler Bui-Palsulich <26876514+tbpg@users.noreply.github.com>
@chingor13 chingor13 merged commit 43bf6de into master Sep 2, 2020
@chingor13 chingor13 deleted the return-pr-number branch September 2, 2020 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants