fix(framework-core): core-library get remote patch ranges #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## comment-pr #84 +/- ##
=============================================
Coverage ? 88.50%
=============================================
Files ? 16
Lines ? 1522
Branches ? 115
=============================================
Hits ? 1347
Misses ? 174
Partials ? 1 Continue to review full report at Codecov.
|
chingor13
requested changes
Aug 17, 2020
src/github-handler/comment-handler/remote-patch-ranges-handler.ts
Outdated
Show resolved
Hide resolved
src/github-handler/comment-handler/remote-patch-ranges-handler.ts
Outdated
Show resolved
Hide resolved
src/github-handler/comment-handler/remote-patch-ranges-handler.ts
Outdated
Show resolved
Hide resolved
bcoe
reviewed
Aug 18, 2020
test/remote-github-patch-text.ts
Outdated
| }); | ||
| }); | ||
|
|
||
| describe('Extracting multiple GitHub files ranges from patch text', () => { |
There was a problem hiding this comment.
I appreciate how well tested this work is 👌
chingor13
requested changes
Aug 18, 2020
chingor13
approved these changes
Aug 18, 2020
test/remote-github-patch-text.ts
Outdated
| }); | ||
| it('Returns a single range file record when there is a single 1 line patch hunk', () => { | ||
| const firstLinePatch = '@@ -1 +1 @@\n-Hello foo\n+'; | ||
| const singlelineFIleName = 'single-line-patch.txt'; |
chingor13
added a commit
that referenced
this pull request
Sep 25, 2020
…n pull requests (#105) * feat(patch text to hunk bounds): support regex for patch texts (#83) * fix(patch text to hunk bounds): support regex for patch texts * more comments and more tests * fix(framework-core): core-library get remote patch ranges (#84) * fix(framework-core): given files old content and new content, compute the valid hunks (#86) * fix(framework-core): parse raw changes to ranges * refactor(framework-core): rename modules, functions, & re-org project structure (#89) * fix(framework-core): hunk to patch object (#91) * feat: build failure message from invalid hunks (#90) * test: add failing stub and test for building the failure message * fix: implement message building * fix: use original line numbers in error message * docs: add docstring * docs: add note about empty input returning empty string * feat(framework-core): comment on prs given suggestions (#93) * feat(framework-core): main interface for create review on a pull request (#114) * feat(framework-core): main interface for create review on a pull request * docs: fix typo * nits and typos... * gts lint warning fix * fix(framework-core): combine review comments (#116) * fix(framework-core): collapsing timeline and inline comments into single review * test: fixed imports * added case when there are out of scope suggestions and no valid suggestions * feat(framework-core): return review number and variable renaming (#117) * feat(framework-core): return review number and variable renaming * lint Co-authored-by: Jeff Ching <chingor@google.com> Co-authored-by: Justin Beckwith <justin.beckwith@gmail.com> Co-authored-by: Benjamin E. Coe <bencoe@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to suggest lines to comment on in a PR, code-suggester needs to know what lines are in-scope. If a line is suggested that does not appear in the PR file hunk, GitHub throws an error. Therefore we will need know each file's patch range for the updated content.
Hence, fetch the remote pull request so that each file's updated patch range is collected: the valid patch ranges.
Some files will not have a patch field returned, usually because the file is too large: invalid files. This is a subset of the total invalid files of that PR. Collect these files as well for future use.
Towards #59