feat(patch text to hunk bounds): support regex for patch texts #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## comment-pr #83 +/- ##
==============================================
+ Coverage 85.86% 87.30% +1.44%
==============================================
Files 14 15 +1
Lines 1238 1379 +141
Branches 81 92 +11
==============================================
+ Hits 1063 1204 +141
Misses 174 174
Partials 1 1
Continue to review full report at Codecov.
|
chingor13
requested changes
Aug 17, 2020
Comment on lines
30
to
33
| const REGEX_MANY_MANY = /@@ -([0-9]+,[0-9]+) \+([0-9]+,[0-9]+) @@\n/g; | ||
| const REGEX_ONE_MANY = /@@ -([0-9]+) \+([0-9]+,[0-9]+) @@\n/g; | ||
| const REGEX_ONE_ONE = /@@ -([0-9]+) \+([0-9]+) @@\n/g; | ||
| const REGEX_MANY_ONE = /@@ -([0-9]+) \+([0-9]+,[0-9]+) @@\n/g; |
There was a problem hiding this comment.
Let's rename these and document what scenarios these cases match to rather than the representation.
| const REGEX_MANY_ONE = /@@ -([0-9]+) \+([0-9]+,[0-9]+) @@\n/g; | ||
|
|
||
| /** | ||
| * Parses the GitHub line-based patch text |
There was a problem hiding this comment.
Parses this into what/for what purpose?
test/regex-patch.ts
Outdated
| }, | ||
| ]; | ||
| it('parses original text for multiline modifies', () => { | ||
| const patch = gitHubListFilesData[0]; |
There was a problem hiding this comment.
Let's split out these fixtures and rename them so it's clear what the scenario is. Reading this test case by itself makes it hard to find the input data.
test/regex-patch.ts
Outdated
| patch: '@@ -1 +0,0 @@\n-hello world', | ||
| }, | ||
| ]; | ||
| it('parses original text for multiline modifies', () => { |
There was a problem hiding this comment.
We have 4 regexes/cases above, but only 3 test cases.
chingor13
approved these changes
Aug 17, 2020
chingor13
added a commit
that referenced
this pull request
Sep 25, 2020
…n pull requests (#105) * feat(patch text to hunk bounds): support regex for patch texts (#83) * fix(patch text to hunk bounds): support regex for patch texts * more comments and more tests * fix(framework-core): core-library get remote patch ranges (#84) * fix(framework-core): given files old content and new content, compute the valid hunks (#86) * fix(framework-core): parse raw changes to ranges * refactor(framework-core): rename modules, functions, & re-org project structure (#89) * fix(framework-core): hunk to patch object (#91) * feat: build failure message from invalid hunks (#90) * test: add failing stub and test for building the failure message * fix: implement message building * fix: use original line numbers in error message * docs: add docstring * docs: add note about empty input returning empty string * feat(framework-core): comment on prs given suggestions (#93) * feat(framework-core): main interface for create review on a pull request (#114) * feat(framework-core): main interface for create review on a pull request * docs: fix typo * nits and typos... * gts lint warning fix * fix(framework-core): combine review comments (#116) * fix(framework-core): collapsing timeline and inline comments into single review * test: fixed imports * added case when there are out of scope suggestions and no valid suggestions * feat(framework-core): return review number and variable renaming (#117) * feat(framework-core): return review number and variable renaming * lint Co-authored-by: Jeff Ching <chingor@google.com> Co-authored-by: Justin Beckwith <justin.beckwith@gmail.com> Co-authored-by: Benjamin E. Coe <bencoe@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get the patch range (start, end) from patch text which gives (start, offset). This range is needed so that from a raw old file and raw new file, we can calculate what lines to suggest edits, and what text file content belong in the lines to suggest.
Given patch text from GitHub which gives output i.e.
@@ -132,7 +132,7 @@ module Test @@ -1000,7 +1000,7 @@ module Testmap the patch text to a list of patch ranges by use of regex.
Towards #59 🦕