Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to update PR on reuse #412

Open
grayside opened this issue Oct 12, 2022 · 0 comments
Open

Add option to update PR on reuse #412

grayside opened this issue Oct 12, 2022 · 0 comments
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@grayside
Copy link

Current Behavior

When using the force: true option to reuse a Pull Request with an updated code suggestion, the existing Pull Request carries the new commit but changes to the title and description on the PR are not processed. (https://github.com/googleapis/code-suggester/blob/main/src/github/open-pull-request.ts#L50)

Requested Behavior

I would like an option such as update-pr-on-reuse so the title and description from my GitHub Workflow is used to update the PR.

Why

I prefer generated PRs to have detailed context about the inputs that went into the code change, and without updating the PR description, this context is out of date with the next commit on the branch. You can see an example of what I hope to enable with this feature at https://github.com/googleapis/google-cloudevents-go/blob/521da225b7e85d6901bdc316b9542d1060aad29e/.github/workflows/generate.yml#L96.

@grayside grayside added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p3 Desirable enhancement or fix. May not be included in next release. labels Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

3 participants
@chingor13 @grayside and others