Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: basic pr opening #33

Merged
merged 1 commit into from Jul 15, 2020
Merged

feat: basic pr opening #33

merged 1 commit into from Jul 15, 2020

Conversation

TomKristie
Copy link
Contributor

Given an origin branch, repo, owner, an upstream owner, and any PR descriptions, create a PR from that origin branch.
It should:

  • invoke the Octokit wrapper (for the GitHub API)
  • invoke the Octokit create PR function and open a PR when all the fields are valid for the GitHub V3 API
  • re-throw the GitHub V3 API error when the API call fails.

Fixes #19

@TomKristie TomKristie requested a review from a team as a code owner July 14, 2020 19:55
@codecov
Copy link

codecov bot commented Jul 14, 2020

Codecov Report

Merging #33 into master will increase coverage by 3.71%.
The diff coverage is 76.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
+ Coverage   58.36%   62.07%   +3.71%     
==========================================
  Files           7        8       +1     
  Lines         281      356      +75     
  Branches       11       13       +2     
==========================================
+ Hits          164      221      +57     
- Misses        117      135      +18     
Impacted Files Coverage Δ
src/github-handler/index.ts 0.00% <0.00%> (ø)
src/types/index.ts 0.00% <0.00%> (ø)
src/github-handler/pr-handler.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96901bf...dac2c91. Read the comment docs.

@chingor13 chingor13 requested a review from sofisl July 14, 2020 20:02
@TomKristie TomKristie added this to the Open-PR-From-Fork milestone Jul 14, 2020
@TomKristie TomKristie added the type: process A process-related concern. May include testing, release, or the like. label Jul 14, 2020
src/github-handler/pr-handler.ts Show resolved Hide resolved
const DEFAULT_PRIMARY = 'master';

/**
* Create a GitHub PR on the upstream organization's repo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for this!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Framework-core: Given an object containing file content, create a PR with that file content from a fork
2 participants