Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: move custom logger configuration into options #212

Merged
merged 5 commits into from Apr 26, 2021

Conversation

chingor13
Copy link
Contributor

Options should be made as optional object properties rather than positional arguments.

@chingor13 chingor13 requested a review from a team April 23, 2021 21:07
@chingor13 chingor13 requested a review from a team as a code owner April 23, 2021 21:07
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 23, 2021
@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #212 (f8024c6) into master (3d4aa4b) will increase coverage by 0.23%.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #212      +/-   ##
==========================================
+ Coverage   88.04%   88.28%   +0.23%     
==========================================
  Files          24       24              
  Lines        2301     2330      +29     
  Branches      168      168              
==========================================
+ Hits         2026     2057      +31     
+ Misses        275      273       -2     
Impacted Files Coverage Δ
src/bin/handle-git-dir-change.ts 79.28% <0.00%> (ø)
src/bin/workflow.ts 83.67% <60.00%> (-0.71%) ⬇️
src/github-handler/pull-request-handler.ts 100.00% <100.00%> (ø)
src/index.ts 98.70% <100.00%> (-0.03%) ⬇️
src/logger.ts 100.00% <100.00%> (+11.11%) ⬆️
src/types.ts 98.48% <100.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecc7b25...f8024c6. Read the comment docs.

@chingor13 chingor13 added the automerge Merge the pull request once unit tests and other checks pass. label Apr 26, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 89a1482 into googleapis:master Apr 26, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 26, 2021
@release-please release-please bot mentioned this pull request Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants