Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: reorganize source code #208

Merged
merged 9 commits into from Apr 26, 2021
Merged

Conversation

chingor13
Copy link
Contributor

@chingor13 chingor13 commented Apr 22, 2021

Cleans up tests to use sinon instead of proxyquire

BREAKING CHANGE: This does not actually break any interfaces that are intended to be public (exported in index.ts), but would be breaking if you are importing from deeply nested paths which is not intended.

BREAKING CHANGE: This does not actually break any interfaces, but would be breaking if you are importing from deeply nested paths which is not supported.
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 22, 2021
@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #208 (5ea549b) into master (3d4aa4b) will decrease coverage by 0.39%.
The diff coverage is 95.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #208      +/-   ##
==========================================
- Coverage   88.04%   87.65%   -0.40%     
==========================================
  Files          24       17       -7     
  Lines        2301     2211      -90     
  Branches      168      168              
==========================================
- Hits         2026     1938      -88     
+ Misses        275      273       -2     
Impacted Files Coverage Δ
src/bin/handle-git-dir-change.ts 79.28% <0.00%> (ø)
src/github/branch.ts 100.00% <ø> (ø)
src/github/commit-and-push.ts 97.84% <ø> (ø)
src/github/fork.ts 100.00% <ø> (ø)
src/github/labels.ts 100.00% <ø> (ø)
src/utils/diff-utils.ts 97.36% <ø> (ø)
src/bin/workflow.ts 83.67% <60.00%> (-0.71%) ⬇️
src/github/review-pull-request.ts 95.10% <95.10%> (ø)
src/github/open-pull-request.ts 100.00% <100.00%> (ø)
src/index.ts 98.70% <100.00%> (-0.03%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89a1482...5ea549b. Read the comment docs.

@chingor13 chingor13 marked this pull request as ready for review April 23, 2021 19:52
@chingor13 chingor13 requested a review from a team April 23, 2021 19:52
@chingor13 chingor13 requested a review from a team as a code owner April 23, 2021 19:52
@chingor13 chingor13 requested a review from bcoe April 23, 2021 20:07
@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 26, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 26, 2021
@chingor13 chingor13 added the automerge Merge the pull request once unit tests and other checks pass. label Apr 26, 2021
@chingor13 chingor13 merged commit 5c2edb1 into googleapis:master Apr 26, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 26, 2021
@chingor13 chingor13 deleted the reorganize branch April 26, 2021 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants