New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: reorganize source code #208
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: This does not actually break any interfaces, but would be breaking if you are importing from deeply nested paths which is not supported.
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Apr 22, 2021
Codecov Report
@@ Coverage Diff @@
## master #208 +/- ##
==========================================
- Coverage 88.04% 87.65% -0.40%
==========================================
Files 24 17 -7
Lines 2301 2211 -90
Branches 168 168
==========================================
- Hits 2026 1938 -88
+ Misses 275 273 -2
Continue to review full report at Codecov.
|
sofisl
reviewed
Apr 23, 2021
chingor13
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Apr 26, 2021
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Apr 26, 2021
JustinBeckwith
approved these changes
Apr 26, 2021
chingor13
added
the
automerge
Merge the pull request once unit tests and other checks pass.
label
Apr 26, 2021
gcf-merge-on-green
bot
removed
the
automerge
Merge the pull request once unit tests and other checks pass.
label
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up tests to use sinon instead of proxyquire
BREAKING CHANGE: This does not actually break any interfaces that are intended to be public (exported in
index.ts
), but would be breaking if you are importing from deeply nested paths which is not intended.