New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: cleanup custom logging #206
feat!: cleanup custom logging #206
Conversation
BREAKING CHANGE: changes the interface to provide a custom logger to our own types, rather than exposing Pino's types.
Codecov Report
@@ Coverage Diff @@
## master #206 +/- ##
==========================================
+ Coverage 88.04% 88.32% +0.27%
==========================================
Files 24 24
Lines 2301 2329 +28
Branches 168 168
==========================================
+ Hits 2026 2057 +31
+ Misses 275 272 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏
going to release a candidate version and batch some other potentially breaking cleanup changes. |
Released this as 2.0.0-candidate.1 and it integrates fine with release-please. |
This changes the logger option provided to
reviewPullRequest()
andcreatePullRequest()
to be a customLogger
interface thatcode-suggester
declares:Pino
logger as well as plain oldconsole
.pino
dependency as we now provide a null default logger implementation.Fixes #178
Fixes #183