feat(framework-core): return review number and variable renaming #117
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed user input for text file content of 'diffs'
rawChanges
todiffContents
.Renamed variable name references to this user diff file contents as well, i.e.
testRawContents
->testDiffContents
Renamed
RawContents
object toFileDiffContents
Changed return type from void to returning the review number, or null if there was no exception but a review was not created. More succinctly, the return type is
number
andnull
.null
was chosen since it clearly indicates the "lack-of-existance" of a review.Moved the logging of successful review into the callee since the
reviewPullRequest
caller method does not always return a number. Having the successful log directly after the corresponding async call was made rather than in the caller allows for better logging control. Now the callee handles the logging of when there are no reviews to be made and when there is a successful review.Towards #105