fix(framework-core): combine review comments #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## comment-pr #116 +/- ##
==============================================
+ Coverage 91.85% 91.87% +0.02%
==============================================
Files 26 25 -1
Lines 2332 2289 -43
Branches 164 161 -3
==============================================
- Hits 2142 2103 -39
+ Misses 189 185 -4
Partials 1 1
Continue to review full report at Codecov.
|
chingor13
requested changes
Sep 15, 2020
| } | ||
| const errorMessage = buildErrorMessage(outOfScopeSuggestions); | ||
| if (errorMessage) { | ||
| logger.warn('Some suggestions could not be made'); |
There was a problem hiding this comment.
I think we're missing the case of no suggestion and no errors (which should do nothing).
There was a problem hiding this comment.
Hm wouldn't it be the case: when we have no suggestions we would still want to comment that out of scope suggestions were generated?
There was a problem hiding this comment.
I propose we should do nothing if we have both no suggestions to make and no out of scope suggestions generated (assuming users care about all suggestions generated). Do you agree?
There was a problem hiding this comment.
Correct, if there are no suggestions and no errors, we should do nothing.
chingor13
approved these changes
Sep 15, 2020
chingor13
added a commit
that referenced
this pull request
Sep 25, 2020
…n pull requests (#105) * feat(patch text to hunk bounds): support regex for patch texts (#83) * fix(patch text to hunk bounds): support regex for patch texts * more comments and more tests * fix(framework-core): core-library get remote patch ranges (#84) * fix(framework-core): given files old content and new content, compute the valid hunks (#86) * fix(framework-core): parse raw changes to ranges * refactor(framework-core): rename modules, functions, & re-org project structure (#89) * fix(framework-core): hunk to patch object (#91) * feat: build failure message from invalid hunks (#90) * test: add failing stub and test for building the failure message * fix: implement message building * fix: use original line numbers in error message * docs: add docstring * docs: add note about empty input returning empty string * feat(framework-core): comment on prs given suggestions (#93) * feat(framework-core): main interface for create review on a pull request (#114) * feat(framework-core): main interface for create review on a pull request * docs: fix typo * nits and typos... * gts lint warning fix * fix(framework-core): combine review comments (#116) * fix(framework-core): collapsing timeline and inline comments into single review * test: fixed imports * added case when there are out of scope suggestions and no valid suggestions * feat(framework-core): return review number and variable renaming (#117) * feat(framework-core): return review number and variable renaming * lint Co-authored-by: Jeff Ching <chingor@google.com> Co-authored-by: Justin Beckwith <justin.beckwith@gmail.com> Co-authored-by: Benjamin E. Coe <bencoe@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collapses timeline and inline comment into a single pull request. This also prompted some refactoring because of the sequence of events change.
Addresses review comment
Towards #105