Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli,action): enable configuring --fork option #109

Merged
merged 4 commits into from Sep 9, 2020

Conversation

chingor13
Copy link
Contributor

Surfaces the option to skip forking to the CLI and to the GitHub action.

@chingor13 chingor13 requested a review from a team September 8, 2020 18:50
@chingor13 chingor13 requested a review from a team as a code owner September 8, 2020 18:50
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 8, 2020
@codecov
Copy link

codecov bot commented Sep 8, 2020

Codecov Report

Merging #109 into master will decrease coverage by 0.39%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
- Coverage   85.66%   85.27%   -0.40%     
==========================================
  Files          14       14              
  Lines        1249     1256       +7     
  Branches       87       92       +5     
==========================================
+ Hits         1070     1071       +1     
- Misses        178      184       +6     
  Partials        1        1              
Impacted Files Coverage Δ
src/bin/code-suggester.ts 0.00% <0.00%> (ø)
src/bin/workflow.ts 96.22% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a1ec95...6b9b54f. Read the comment docs.

@chingor13 chingor13 marked this pull request as draft September 8, 2020 20:37
@chingor13 chingor13 marked this pull request as ready for review September 8, 2020 20:52
@chingor13 chingor13 requested a review from bcoe September 8, 2020 21:02
@TomKristie
Copy link
Contributor

I believe you need to this fork field added in the default-options-handler.ts. That file takes the inputs and maps them all to an object with all the fields guaranteed.

@bcoe bcoe added the cla: yes This human has signed the Contributor License Agreement. label Sep 9, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit fd77d4a into googleapis:master Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants