Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is there an option to stop the profiler? #876

Open
dudicp opened this issue Jul 6, 2023 · 3 comments
Open

Is there an option to stop the profiler? #876

dudicp opened this issue Jul 6, 2023 · 3 comments
Labels
api: cloudprofiler Issues related to the googleapis/cloud-profiler-nodejs API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@dudicp
Copy link

dudicp commented Jul 6, 2023

I would like to start and the stop the profiler for a configured duration of time and stop it once the time reached, is there an API to stop the profiler?
@dudicp dudicp added priority: p3 Desirable enhancement or fix. May not be included in next release. type: question Request for information or clarification. Not an issue. labels Jul 6, 2023
@product-auto-label product-auto-label bot added the api: cloudprofiler Issues related to the googleapis/cloud-profiler-nodejs API. label Jul 6, 2023
@akosyakov
Copy link

Hey, also was looking for the same capability. I would like to control if via a feature flag.

@akosyakov
Copy link

It also looks like will be useful while shutting down a server:

cloud-profiler-nodejs/src/profiler.ts

Lines 433 to 436 in 00316e8

* TODO (issue #28): right now, this call could hang for up to an hour when
* this method is the only thing on the event loop, keeping the program open
* even when all work is done. Should expose the ability to cancel the http
* request made here, and then determine when to cancel this request.

@akosyakov akosyakov mentioned this issue Sep 22, 2023
Merged
14 tasks
@aabmass
Copy link
Collaborator

aabmass commented Feb 2, 2024

Unfortunately not right now. I'll leave this open as a feature request but we aren't willing to accept a contribution for this right now

@aabmass aabmass added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed type: question Request for information or clarification. Not an issue. labels Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: cloudprofiler Issues related to the googleapis/cloud-profiler-nodejs API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aabmass @akosyakov @dudicp