Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misattributed parent with accurate line number #349

Open
nolanmar511 opened this issue Nov 30, 2018 · 1 comment
Open

Misattributed parent with accurate line number #349

nolanmar511 opened this issue Nov 30, 2018 · 1 comment
Labels
api: cloudprofiler Issues related to the googleapis/cloud-profiler-nodejs API. external This issue is blocked on a bug with the actual product. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@nolanmar511
Copy link
Contributor

Profiling with agent from PR #258
This is the script I profiled (I ran with --noturbo-inlining):
busybench-3.txt

This is the javascript object I return from the binding: parent-wrong.txt.
The function f2 is a a child of busyloop, in this, so it's not just and issue with serialization. There's a node where f2's line number is 46 (the line number from which f1 is called)

Here's a graph of the profile:
image

@psmarshall -- any ideas?

@nolanmar511 nolanmar511 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Nov 30, 2018
@nolanmar511
Copy link
Contributor Author

The line number for the sample with the strange parent is the line number of the function's declaration.

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Jun 4, 2019
@nolanmar511 nolanmar511 added external This issue is blocked on a bug with the actual product. and removed 🚨 This issue needs some love. labels Sep 19, 2019
@google-cloud-label-sync google-cloud-label-sync bot added the api: cloudprofiler Issues related to the googleapis/cloud-profiler-nodejs API. label Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: cloudprofiler Issues related to the googleapis/cloud-profiler-nodejs API. external This issue is blocked on a bug with the actual product. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants