Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

fix: do not throw when meeting empty source map file #992

Merged
merged 5 commits into from
Jul 9, 2021

Conversation

Louis-Ye
Copy link
Contributor

@Louis-Ye Louis-Ye commented Jul 8, 2021

The debugger agent should not throw when meeting empty source map files, so that when there are such source map files, the agent can still start normally.

Fixes #989

@Louis-Ye Louis-Ye requested review from a team as code owners July 8, 2021 13:38
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 8, 2021
@product-auto-label product-auto-label bot added the api: clouddebugger Issues related to the googleapis/cloud-debug-nodejs API. label Jul 8, 2021
@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #992 (bee6d68) into master (cc8eff8) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #992      +/-   ##
==========================================
- Coverage   66.90%   66.86%   -0.04%     
==========================================
  Files          20       20              
  Lines        1668     1666       -2     
  Branches      340      339       -1     
==========================================
- Hits         1116     1114       -2     
  Misses        474      474              
  Partials       78       78              
Impacted Files Coverage Δ
src/agent/io/sourcemapper.ts 89.88% <ø> (+1.97%) ⬆️
src/agent/debuglet.ts 80.64% <0.00%> (-0.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc8eff8...bee6d68. Read the comment docs.

@mctavish mctavish added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 9, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 9, 2021
@mctavish mctavish merged commit 374c1a7 into googleapis:master Jul 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: clouddebugger Issues related to the googleapis/cloud-debug-nodejs API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to start when there are empty source map files
3 participants