This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
fix: periodically reset v8 session to prevent memory leak #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch makes the cloud debugger reset the v8 debugger session to prevent the memory leak caused by v8 breakpoint hits whenenever the number of breakpoint hits reach the threshold. The threshold can be set through environment variable. Fixes googleapis#811
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: clouddebugger
Codecov Report
@@ Coverage Diff @@
## master #957 +/- ##
==========================================
+ Coverage 66.02% 66.36% +0.33%
==========================================
Files 20 20
Lines 1619 1638 +19
Branches 334 336 +2
==========================================
+ Hits 1069 1087 +18
- Misses 472 473 +1
Partials 78 78
Continue to review full report at Codecov.
|
JustinBeckwith
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
bcoe
approved these changes
May 21, 2021
cdbg-integration-tests
approved these changes
May 31, 2021
mctavish
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes the cloud debugger reset the v8 debugger session to
prevent the memory leak caused by v8 breakpoint hits whenenever the
number of breakpoint hits reach the threshold.
The threshold can be set through upon the agent is started during initialization.
Fixes #811