This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
feat: Add region in Debuggee labels in GCF env #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Read GCF region from either the environment or GCP metadata service * Add the region into Debuggee labels * Add the corresponding tests Fixes googleapis#950
product-auto-label
bot
added
the
api: clouddebugger
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #951 +/- ##
==========================================
+ Coverage 66.00% 66.02% +0.02%
==========================================
Files 20 20
Lines 1606 1619 +13
Branches 330 334 +4
==========================================
+ Hits 1060 1069 +9
- Misses 470 472 +2
- Partials 76 78 +2
Continue to review full report at Codecov.
|
gugupopes123
referenced
this pull request
Apr 30, 2021
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
mctavish
suggested changes
May 3, 2021
bcoe
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
mctavish
approved these changes
May 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #950