This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
fix: warn if maxDataSize=0 #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
@DominicKramer FYI: You disabled a test that doesn't have to do with circular references (but it still is because of changes in the Inspector API in Node 12). I've re-enabled it conditionally running on Node 11 only. |
Codecov Report
@@ Coverage Diff @@
## master #744 +/- ##
=======================================
Coverage 85.45% 85.45%
=======================================
Files 13 13
Lines 949 949
Branches 193 193
=======================================
Hits 811 811
Misses 76 76
Partials 62 62
Continue to review full report at Codecov.
|
DominicKramer
approved these changes
Aug 19, 2019
kjin
force-pushed
the
no-more-circ
branch
2 times, most recently
from
1eb7746
to
9af7c88
Compare
Also, this is not reported in breakpoints in Node 12+, so modify a test to reflect this.
|
@DominicKramer Why is it trying to run system tests on Node 8? |
|
@kjin I think running system tests on Node 8 is an oversight. They should be run on the newest Node. We can address that issue in a followup PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stable object ID was removed in Node 12, so maxDataSize=0 is once again dangerous to use. We warn if the user sets it to this value in Node 12.
This also disables the circular reference test for Node 12+.
Fixes #742