Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classes in Java artifact do not match the protos shipped with it #83

Closed
thesamet opened this issue Nov 14, 2020 · 5 comments
Closed

Classes in Java artifact do not match the protos shipped with it #83

thesamet opened this issue Nov 14, 2020 · 5 comments
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: question Request for information or clarification. Not an issue.

Comments

@thesamet
Copy link

In the 2.0.1 jar, google/api/endpoint.proto contains a repeated string features = 4, however the corresponding Java class file doesn't have any of the methods corresponding to this field.

thesamet added a commit to scalapb/common-protos that referenced this issue Nov 14, 2020
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Feb 25, 2021
@miraleung miraleung added priority: p2 Moderately-important priority. Fix may not be included in next release. type: question Request for information or clarification. Not an issue. and removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Feb 25, 2021
@miraleung miraleung self-assigned this Feb 25, 2021
@miraleung
Copy link

Closing because the Bazel build doesn't have relevant rules. Please feel free to reopen the Java build definition is root-caused back to this repo.

@thesamet
Copy link
Author

@miraleung
I am not sure why this issue was closed. The Java classes that are shipped with the jar artifact do not match the protos that are shipped within the same jar. This is also occurring with 2.1.0. I am not sure what you meant by "Please feel free to reopen the Java build definition is root-caused back to this repo." - is there an upstream ticket that need to be filed?

@thesamet
Copy link
Author

thesamet commented Mar 27, 2021

@miraleung what is the next step for this issue to be resolved? I don't have a re-open button on this issue.

@miraleung
Copy link

The Bazel build definitions in this repo all pertain to proto_package, so there doesn't seem to be any build definition that produces a Java artifact. If you find one though, please link it here. Otherwise, the discrepancy is either due to an upstream issue in the protobuf compiler or something downstream that packages the protos into a jar.

Note that this repo is as actively maintained as googleapis, which contains a superset of all these protos, so consider using that instead.

@thesamet
Copy link
Author

Ack, thanks for clarifying the maven jar is published elsewhere. Filed googleapis/java-common-protos#134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: question Request for information or clarification. Not an issue.
Projects
None yet
Development

No branches or pull requests

3 participants