Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

fix: Fix PathTemplate custom verb logic matching and instantiating #244

Merged
merged 2 commits into from Jul 20, 2021

Conversation

vam-google
Copy link
Contributor

@vam-google vam-google commented Jul 18, 2021

The custom verb (:literal at the end of a url path) was not handled properly. On instantiation : was incorrectly replaced with /. On matching :literal was not properly recognized as a valid input.

Also specified the jacoco version explicitly (points to the latest version on the moment of creation of this PR). Without this chagne jacoco was failing on jdk11+ (worked on jdk8 that is why CI was succeeding).

The custom verb (":literal" at the end of a url path) was not handled properly. On instantiation `:` was incorrectly replaced with `/`. On matching `:literal` was not properly recognized as a valid input.
@vam-google vam-google requested a review from a team as a code owner July 18, 2021 09:06
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 18, 2021
@vam-google vam-google merged commit d4913d3 into googleapis:master Jul 20, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 27, 2021
🤖 I have created a release \*beep\* \*boop\*
---
### [1.10.5](https://www.github.com/googleapis/api-common-java/compare/v1.10.5...v1.10.5) (2021-07-27)

### Bug Fixes

* Fix PathTemplate custom verb logic matching and instantiating ([#244](https://www.github.com/googleapis/api-common-java/issues/244)) ([d4913d3](https://www.github.com/googleapis/api-common-java/commit/d4913d33ff2153cb3a8f6382ab8d918980f542ea))


### Build System

* migrate to google sonatype endpoint ([#248](https://www.github.com/googleapis/api-common-java/issues/248)) ([c3ab73e](https://www.github.com/googleapis/api-common-java/commit/c3ab73eca99f3036a26fe10a880c1ff068efc0da))


### Dependencies

* update dependency com.google.auto.value:auto-value to v1.8.2 ([#242](https://www.github.com/googleapis/api-common-java/issues/242)) ([5de2f3e](https://www.github.com/googleapis/api-common-java/commit/5de2f3edfcaed42061ad7dbc4efc886587c0e769))
* update dependency com.google.auto.value:auto-value-annotations to v1.8.2 ([#243](https://www.github.com/googleapis/api-common-java/issues/243)) ([53d6d38](https://www.github.com/googleapis/api-common-java/commit/53d6d38ac0a7d6dc5738823d69ac96d1eadd23a3))
* update dependency com.google.errorprone:error_prone_annotations to v2.8.0 ([#245](https://www.github.com/googleapis/api-common-java/issues/245)) ([8889689](https://www.github.com/googleapis/api-common-java/commit/88896894b821771293cda2d4b7a2f6027ee20ef4))
* update dependency io.codearte.gradle.nexus:gradle-nexus-staging-plugin to v0.30.0 ([#239](https://www.github.com/googleapis/api-common-java/issues/239)) ([2ca4359](https://www.github.com/googleapis/api-common-java/commit/2ca4359127cc2f8eddb81e8091362a75e1e6e38e))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
3 participants