From 6af8e24a6252da7217e7c53f86cbb2b321327fc4 Mon Sep 17 00:00:00 2001
From: Brian Chen <chenbrian@google.com>
Date: Fri, 17 Jul 2020 10:29:26 -0700
Subject: [PATCH] feat: add ApiFutures.successfulAsList (#163)

---
 src/main/java/com/google/api/core/ApiFutures.java | 15 +++++++++++++++
 .../java/com/google/api/core/ApiFuturesTest.java  | 11 +++++++++++
 2 files changed, 26 insertions(+)

diff --git a/src/main/java/com/google/api/core/ApiFutures.java b/src/main/java/com/google/api/core/ApiFutures.java
index d02892619..e25170fea 100644
--- a/src/main/java/com/google/api/core/ApiFutures.java
+++ b/src/main/java/com/google/api/core/ApiFutures.java
@@ -172,6 +172,21 @@ public ListenableFuture<? extends V> apply(ApiFuture<? extends V> apiFuture) {
                   }
                 })));
   }
+
+  @BetaApi
+  public static <V> ApiFuture<List<V>> successfulAsList(
+      Iterable<? extends ApiFuture<? extends V>> futures) {
+    return new ListenableFutureToApiFuture<>(
+        Futures.successfulAsList(
+            Iterables.transform(
+                futures,
+                new Function<ApiFuture<? extends V>, ListenableFuture<? extends V>>() {
+                  public ListenableFuture<? extends V> apply(ApiFuture<? extends V> apiFuture) {
+                    return listenableFutureForApiFuture(apiFuture);
+                  }
+                })));
+  }
+
   /*
    * @deprecated Use {@linkplain #transformAsync(ApiFuture, ApiFunction, Executor) the
    * overload that requires an executor}. For identical behavior, pass {@link
diff --git a/src/test/java/com/google/api/core/ApiFuturesTest.java b/src/test/java/com/google/api/core/ApiFuturesTest.java
index de10b7ee8..c726bf278 100644
--- a/src/test/java/com/google/api/core/ApiFuturesTest.java
+++ b/src/test/java/com/google/api/core/ApiFuturesTest.java
@@ -154,6 +154,17 @@ public void testAllAsList() throws Exception {
     assertThat(listFuture.get()).containsExactly(1, 2).inOrder();
   }
 
+  @Test
+  public void successfulAllAsList() throws Exception {
+    SettableApiFuture<Integer> inputFuture1 = SettableApiFuture.<Integer>create();
+    SettableApiFuture<Integer> inputFuture2 = SettableApiFuture.<Integer>create();
+    ApiFuture<List<Integer>> listFuture =
+        ApiFutures.successfulAsList(ImmutableList.of(inputFuture1, inputFuture2));
+    inputFuture1.set(1);
+    inputFuture2.setException(new Exception());
+    assertThat(listFuture.get()).containsExactly(1, null).inOrder();
+  }
+
   @Test
   public void testTransformAsync() throws Exception {
     ApiFuture<Integer> inputFuture = ApiFutures.immediateFuture(0);