Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will DAI support DASH streaming in the future? #1115

Open
KrooCiso opened this issue Jul 31, 2023 · 5 comments
Open

Will DAI support DASH streaming in the future? #1115

KrooCiso opened this issue Jul 31, 2023 · 5 comments
Assignees

Comments

@KrooCiso
Copy link

Hello, will DAI support DASH streaming in the future?

@Kiro705
Copy link
Member

Kiro705 commented Aug 18, 2023

Hello @KrooCiso ,

Previously the work for DASH was blocked by support missing for DASH streams in the plugins used to implement stream playback. Would you know if support DASH streams with ads has been implemented in the videoJS ecosystem?

I can work on adding that support, if it is feasible.

Thank you,
Jackson
IMA SDK team

@KrooCiso
Copy link
Author

KrooCiso commented Aug 21, 2023

@Kiro705
Thank you for your reply.

well...I'm not quite certain.

Because I have seen samples of Dash in googleads-ima-html5-dai, and I have tried it and it indeed works:
https://github.com/googleads/googleads-ima-html5-dai/tree/main/dash_js/simple

Moreover, the plugin (http-streaming) for videojs also supports the Dash format in its Streaming Formats:
https://github.com/videojs/http-streaming/blob/main/docs/supported-features.md

Does this achieve the conditions for supporting Dash?

@Kiro705
Copy link
Member

Kiro705 commented Aug 25, 2023

Thanks for taking a look, @KrooCiso ,

I will look into if updating the dependency on http-streaming fixes the issue with DASH streams.

Jackson
IMA SDK team

@KrooCiso
Copy link
Author

KrooCiso commented Aug 29, 2023

@Kiro705
Thank you~

@Kiro705
Copy link
Member

Kiro705 commented Dec 28, 2023

Hello @KrooCiso ,

I was looking into this, but can't figure out what to listen to during a DASH stream in order to pass the metadata to the IMA SDK. Currently this is done for HLS streams here , but it is not triggering for the DASH stream. I tried the different listeners used in the IMA handling metadata guide, but those listeners did not trigger easier.

If you, or someone else is able to add any additional information, or ideally a code snippet of how the plugin should handle DASH stream metadata, that would really be helpful.

Thank you,
Jackson
IMA SDK team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants