failed to compile by using AS 4.1.0

[samlu]

Android Studio 4.1.0 no more supports BuildConfig.VERSION_NAME for library projects.
See https://developer.android.com/studio/releases/gradle-plugin#behavior_changes for details.

It results in the related code won't pass the compilation. Here listed are some examples.

googleads-mobile-android-mediation/ThirdPartyAdapters/facebook/facebook/src/main/java/com/google/ads/mediation/facebook/FacebookMediationAdapter.java

Lines 148 to 150 in f89acf1

	@Override
	public VersionInfo getVersionInfo() {
	String versionString = BuildConfig.VERSION_NAME;

googleads-mobile-android-mediation/ThirdPartyAdapters/facebook/facebook/src/main/java/com/google/ads/mediation/facebook/FacebookInitializer.java

Lines 48 to 49 in 189d8f8

	AudienceNetworkAds.buildInitSettings(context)
	.withMediationService("GOOGLE:" + BuildConfig.VERSION_NAME)

Other mediation SDKs have the same issue.

[ericleich]

@samlu we discovered the same yesterday and are working on a solution for it by defining a custom build config parameter.

That said, are you having an issue including the already compiled Facebook adapter as recommended here, or are you trying to build the Facebook adapter yourself? I'd only suspect you'd have the problem if you're trying to build yourself.

[samlu]

Looking forward to seeing the new solution.

Yes, I am building the FAN adapter myself.

[ericleich]

@samlu So we haven't added this to Facebook yet as we haven't had to make a change on their adapter yet or do a release, but to unblock you, 908719f is an example of the approach we're taking on other adapters.

The BuildConfig generated by AS 4.1.0 doesn't have VERSION_NAME or VERSION_CODE anymore. We opted to define our own custom variable ADAPTER_VERSION instead, and use that in the code. By using a different custom field name as opposed to VERSION_NAME, it's compatible with older android studio versions (which would otherwise generate that field twice and fail to compile).