Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Logging Using REST Transport #414

Open
roydidier opened this issue Sep 4, 2020 · 8 comments
Open

No Logging Using REST Transport #414

roydidier opened this issue Sep 4, 2020 · 8 comments
Labels
enhancement New feature or request

Comments

@roydidier
Copy link

I am using Google Ads client library V5 and I have no log generated

I have set logging parameters into google_ads_php.ini
[LOGGING]
; Optional logging settings.
logFilePath = "/home/metaio-dev-di/google-ads-php/V5/GoogleAdsApi.log"
logLevel = "DEBUG"

I don't find what is wrong

thanks

@PierrickVoulet
Copy link
Collaborator

PierrickVoulet commented Sep 4, 2020

Hi @roydidier - I just tested on my side but did not replicate, I see DEBUG logs in the file I specified. Could you give more detail about your setup: OS, PHP, protobuf, transport? Also did you migrate from an older version of the library or is this a brand new setup?

@PierrickVoulet PierrickVoulet self-assigned this Sep 4, 2020
@roydidier
Copy link
Author

Hi Pierrick

thany you for you quick answer.
Linux version 4.15.0-109-generic (buildd@lgw01-amd64-010) (gcc version 7.5.0 (Ubuntu 7.5.0-3ubuntu1~18.04))
PHP 7.2.33
It was working fine with Google Ads API V1 and V2 and I see now that log is not writtten anymore since middle of june . I don't remember having changing anything at this time.
I am currently migrating to V5 and get the same issue.

where can I find the protobuf and tranport info?

thanks

@roydidier
Copy link
Author

roydidier commented Sep 8, 2020 via email

@PierrickVoulet
Copy link
Collaborator

Hello Didier,

I replicate using the REST transport. Could you confirm that you are using REST as a transport on your end? This should be the case if you do not have the gRPC PHP extension installed and configured on the environment.

If you do use REST, the best workaround for now would be to switch to gRPC. You would be able to do this following the instructions in the requirements section of our documentation.

@PierrickVoulet PierrickVoulet added the bug Something isn't working label Sep 8, 2020
@roydidier
Copy link
Author

roydidier commented Sep 9, 2020 via email

@PierrickVoulet PierrickVoulet changed the title logging not written No Logging Using REST Transport Sep 9, 2020
@PierrickVoulet
Copy link
Collaborator

PierrickVoulet commented Sep 9, 2020

I dug a bit more on this: this is unrelated to the interceptor reimplementation that has been done in V3 as I replicate the issue with V2.

@PierrickVoulet PierrickVoulet added enhancement New feature or request and removed bug Something isn't working labels Sep 9, 2020
@PierrickVoulet PierrickVoulet removed their assignment Dec 5, 2020
@PierrickVoulet
Copy link
Collaborator

This feature depends on the gax-php dependency, a feature request googleapis/gax-php/issues/234 was created on their repository.

@jabeztadesse
Copy link

Enabling gRPC solved it for me ... Thanks @PierrickVoulet! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants