Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for estimation of crp_alpha #4

Open
wq2012 opened this issue Nov 14, 2018 · 5 comments
Open

Add support for estimation of crp_alpha #4

wq2012 opened this issue Nov 14, 2018 · 5 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@wq2012
Copy link
Member

wq2012 commented Nov 14, 2018

Currently in this open source version, crp_alpha is passed in as an argument.

We need to add the support to estimate it from training data.

@wq2012 wq2012 added the enhancement New feature or request label Nov 15, 2018
@fanlu
Copy link

fanlu commented Jan 18, 2019

How to fix the total number of speakers? In most call center scenario, there are only 2 or 3 speakers.

@wq2012
Copy link
Member Author

wq2012 commented Jan 18, 2019

@fanlu The whole idea of UIS-RNN is to be able to handle unbounded number of speakers by learning from examples, instead of enforcing the number of speakers.

If you train UIS-RNN with call center audios where there are always 2 or 3 speakers, it should be able to predict at most 2 or 3 speakers, without requiring additional constraints.

However, since you asked, let me create a feature request issue for it. But likely we won't work on it for any time soon.

@suzinia
Copy link

suzinia commented Aug 28, 2019

Hi, do you have any update about this issue?
Or do you have any suggestion related to the input parameter adjustment when the system tends to add too many speakers?

@wq2012
Copy link
Member Author

wq2012 commented Aug 28, 2019

@suzinia Unfortunately no, since some core members have left the team.

You can try to locally apply #56 to constrain the number of speakers. It's not really very correct, but may solve your immediate problem.

@suzinia
Copy link

suzinia commented Aug 28, 2019

Thanks, I'll try that out!

wq2012 added a commit that referenced this issue Dec 13, 2019
* add crp_alpha support

* add docstring

* fix bad indent

* move file to contrib and fix pylint warning

* add unittest for get_prior_args.py

* remove tqdm module

* add file-level docstring, change module and method name, add a test

* fix a bad indent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants