Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port a core set of unit tests to kotlin #887

Open
kevinb9n opened this issue Jun 26, 2021 · 2 comments
Open

Port a core set of unit tests to kotlin #887

kevinb9n opened this issue Jun 26, 2021 · 2 comments
Labels
P3 not scheduled type=enhancement Make an existing feature better

Comments

@kevinb9n
Copy link
Contributor

A number of issues mention kotlin: https://github.com/google/truth/issues?q=is%3Aissue+is%3Aopen+kotlin

Before worrying about any of them I think we should have a core set of unit tests ported to Kotlin. These only need to cover varying API shapes, not all variations of behavior. (I'd put this requirement on any library that wants to claim it's for both languages.) Of course, a custom subject or two should be included.

(I might actually be able to take this task, but not promising yet.)

@cpovirk
Copy link
Member

cpovirk commented Jun 28, 2021

This may already be what you have in mind, but I suspect that we'll learn more from (re)writing the tests of a "real" project in Kotlin than from rewriting Truth's own tests in Kotlin. Truth's own tests tend to be weird in a number of ways (example).

Truth will of course still need Kotlin tests (beyond the ones we have for our single (and currently internal-only) Kotlin extension). I just don't think that our existing tests will shed a lot of light on what normal users will need.

(Again, this might be what you have in mind; I wasn't sure how to read "ported" or perhaps how to interpret which "core set of unit tests" we would be talking about.)

@kevinb9n
Copy link
Contributor Author

Yes, scratch all implication of where the tests come from; the point was just that a small set of tests covering different API interactions should exist in both languages.

@netdpb netdpb added P3 not scheduled type=other Miscellaneous activities not covered by other type= labels labels Jun 28, 2021
@netdpb netdpb added type=enhancement Make an existing feature better and removed type=other Miscellaneous activities not covered by other type= labels labels Jul 2, 2021
@kevinb9n kevinb9n removed their assignment Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 not scheduled type=enhancement Make an existing feature better
Projects
None yet
Development

No branches or pull requests

3 participants