Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PEP 646 - Variadic Generics #1525

Open
rchen152 opened this issue Nov 3, 2023 · 6 comments
Open

Support PEP 646 - Variadic Generics #1525

rchen152 opened this issue Nov 3, 2023 · 6 comments
Labels
cat: generics Generic, TypeVar, containers enhancement

Comments

@rchen152
Copy link
Contributor

rchen152 commented Nov 3, 2023

https://peps.python.org/pep-0646/
@rchen152 rchen152 added enhancement cat: generics Generic, TypeVar, containers labels Nov 3, 2023
@AlexWaygood AlexWaygood mentioned this issue Nov 14, 2023
Closed
5 tasks
@AlexWaygood
Copy link
Contributor

As a first step, would it maybe be possible to have pytype gracefully fallback to Any if it sees Unpack[] being used in a type annotation? Currently using Unpack[] anywhere seems to make pytype crash, which is blocking a couple of typeshed PRs (python/typeshed#11015, python/typeshed#11014).

No worries if this is difficult to do, though; there's no great rush here in getting those typeshed PRs merged!

@rchen152
Copy link
Contributor Author

I can certainly give it a try.

@rchen152 rchen152 self-assigned this Nov 29, 2023
rchen152 added a commit that referenced this issue Dec 7, 2023
@rchen152
Allow typing.Unpack to be parameterized.
bbf10c1 
For #1525.

PiperOrigin-RevId: 588874437
@rchen152
Copy link
Contributor Author

rchen152 commented Dec 7, 2023

Sorry, it took me a while to get to this. But I should be able to cut a release with a fix for the Unpack crash tomorrow or early next week.

@AlexWaygood
Copy link
Contributor

No worries at all -- thanks so much!

rchen152 added a commit that referenced this issue Dec 8, 2023
@rchen152
Do another PyPI release to get out an Unpack fix that typeshed needs.
4c2b05f 
For #1525.

PiperOrigin-RevId: 589185165
@rchen152 rchen152 mentioned this issue Dec 8, 2023
Merged
@rchen152
Copy link
Contributor Author

rchen152 commented Dec 8, 2023

Ok, version 2023.12.8 has the Unpack fix =)

@AlexWaygood
Copy link
Contributor

Ok, version 2023.12.8 has the Unpack fix =)

Thank you so much — both the typeshed changes have been merged now <3

@Dreamsorcerer Dreamsorcerer mentioned this issue Dec 11, 2023
Open
@AlexWaygood AlexWaygood mentioned this issue Feb 17, 2024
Open
rchen152 added a commit that referenced this issue Mar 11, 2024
@rchen152
Support typing_extensions.Unpack usage in typeshed.
5fb7610 
Until we add real support for PEP 646, just rewrites Unpack to Any.

For #1525.

PiperOrigin-RevId: 614778236
This was referenced Mar 13, 2024
Draft
Draft
@rchen152 rchen152 removed their assignment Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cat: generics Generic, TypeVar, containers enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rchen152 @AlexWaygood