Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support code coverage in javascript test #797

Open
Louis-Ye opened this issue Aug 16, 2023 · 1 comment
Open

Support code coverage in javascript test #797

Louis-Ye opened this issue Aug 16, 2023 · 1 comment
Labels
Priority: p3 Buganizer priority - P3 type: cleanup Buganizer type - Internal Cleanup

Comments

@Louis-Ye
Copy link
Collaborator

After fixing #791 , we should make the tests support code coverage to make the tests more useful.

If the web test is run through chromedp, then one option is to make use of the chrome devtools profiler (profiler.startPreciseCoverage method) to collect the coverage info of the javascript files, and convert it into the code coverage format (example format from the current report coverage.txt, generated by go -coverprofile in test.sh: github.com/google/pprof/profile/prune.go:152.2,152.12 1 2)

@Louis-Ye Louis-Ye added type: feat Buganizer type - Feature Request Priority: p2 Buganizer priority - P2 labels Aug 16, 2023
@Louis-Ye Louis-Ye changed the title Support dev coverage in javascript test Support code coverage in javascript test Aug 16, 2023
@aalexand aalexand added Priority: p3 Buganizer priority - P3 type: cleanup Buganizer type - Internal Cleanup and removed Priority: p2 Buganizer priority - P2 type: feat Buganizer type - Feature Request labels Aug 20, 2023
@aalexand
Copy link
Collaborator

Changed to type:cleanup since it's not really a feature - I suggest we use feature type only for user-visible feature requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: p3 Buganizer priority - P3 type: cleanup Buganizer type - Internal Cleanup
Projects
None yet
Development

No branches or pull requests

2 participants