Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add period (sampling) information in pprof web viewer. #715

Open
bwplotka opened this issue Jul 27, 2022 · 0 comments
Open

Add period (sampling) information in pprof web viewer. #715

bwplotka opened this issue Jul 27, 2022 · 0 comments
Labels
Priority: p3 Buganizer priority - P3 type: feat Buganizer type - Feature Request

Comments

@bwplotka
Copy link

Thanks for the amazing project!

It would be amazing to have information about the period (so sampling) of the profiles we are analysing. I would expect it to see in pop up when clicking on the right menu item with the file name and sample type, but it's not there:

image

Proposal

  • Add field Sampling: to the mentioned pop-up based on period and period_type. E.g. for my profile above it would be Sampling: 512 KB (space).

Question

Am I right that the only way to discover the period right now is through -raw? e.g.:

go tool pprof -raw ~/Downloads/heap | head
PeriodType: space bytes
Period: 524288
Time: 2022-07-13 21:32:01.407524692 +0200 CEST
Samples:
alloc_objects/count alloc_space/bytes inuse_objects/count inuse_space/bytes
        341     525056          0          0: 1 2 3 4 5 6 7 8 9 10 11
                bytes:[1536]
      10923     524312          0          0: 12 13 14 14 15 16 17
                bytes:[48]
       8192     524320          0          0: 18 19 20 21 22 23 24 10 11
@Louis-Ye Louis-Ye added type: feat Buganizer type - Feature Request Priority: p3 Buganizer priority - P3 labels Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: p3 Buganizer priority - P3 type: feat Buganizer type - Feature Request
Projects
None yet
Development

No branches or pull requests

2 participants