Doesn't build with Boost outcome

[davispuh]

When trying to build on Arch Linux with Boost outcome

-- Could NOT find outcome (missing: outcome_DIR)
Couldn't find outcome as a distinct package. Trying to use the version from Boost.
-- Found Boost: /usr/lib/cmake/Boost-1.81.0/BoostConfig.cmake (found version "1.81.0")
Found outcome in Boost!

/mnt/AUR/orbit-git/src/orbit/src/UserSpaceInstrumentation/AccessTraceesMemory.cpp: In function ‘ErrorMessageOr<orbit_user_space_instrumentation::AddressRange> orbit_user_space_instrumentation::GetExistingExecutableMemoryRegion(pid_t, uint64_t)’:
/mnt/AUR/orbit-git/src/orbit/third_party/Outcome/include/outcome.hpp:33:3: error: expected primary-expression before ‘)’ token
33 |   BOOST_OUTCOME_TRY2_SUCCESS_LIKELY(BOOST_OUTCOME_TRY_UNIQUE_NAME, result, expr)
|   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/boost/outcome/try.hpp:159:47: note: in expansion of macro ‘OUTCOME_TRY_INVOKE_TRY2’
159 | #define BOOST_OUTCOME_TRY_OVERLOAD_GLUE(x, y) x y
|                                               ^
/mnt/AUR/orbit-git/src/orbit/src/UserSpaceInstrumentation/AccessTraceesMemory.cpp:55:3: note: in expansion of macro ‘OUTCOME_TRY’
55 |   OUTCOME_TRY(auto&& maps, ReadFileToString(absl::StrFormat("/proc/%d/maps", pid)));
|   ^~~~~~~~~~~
/mnt/AUR/orbit-git/src/orbit/third_party/Outcome/include/outcome.hpp:33:3: error: expected ‘>’ before ‘&&’ token
33 |   BOOST_OUTCOME_TRY2_SUCCESS_LIKELY(BOOST_OUTCOME_TRY_UNIQUE_NAME, result, expr)
|   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/boost/outcome/try.hpp:159:47: note: in expansion of macro ‘OUTCOME_TRY_INVOKE_TRY2’
159 | #define BOOST_OUTCOME_TRY_OVERLOAD_GLUE(x, y) x y
|                                               ^
/mnt/AUR/orbit-git/src/orbit/src/UserSpaceInstrumentation/AccessTraceesMemory.cpp:55:3: note: in expansion of macro ‘OUTCOME_TRY’
55 |   OUTCOME_TRY(auto&& maps, ReadFileToString(absl::StrFormat("/proc/%d/maps", pid)));
|   ^~~~~~~~~~~
/mnt/AUR/orbit-git/src/orbit/third_party/Outcome/include/outcome.hpp:33:3: error: expected ‘(’ before ‘&&’ token
33 |   BOOST_OUTCOME_TRY2_SUCCESS_LIKELY(BOOST_OUTCOME_TRY_UNIQUE_NAME, result, expr)
|   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/boost/outcome/try.hpp:159:47: note: in expansion of macro ‘OUTCOME_TRY_INVOKE_TRY2’
159 | #define BOOST_OUTCOME_TRY_OVERLOAD_GLUE(x, y) x y
|                                               ^
/mnt/AUR/orbit-git/src/orbit/src/UserSpaceInstrumentation/AccessTraceesMemory.cpp:55:3: note: in expansion of macro ‘OUTCOME_TRY’
55 |   OUTCOME_TRY(auto&& maps, ReadFileToString(absl::StrFormat("/proc/%d/maps", pid)));
|   ^~~~~~~~~~~
/mnt/AUR/orbit-git/src/orbit/third_party/Outcome/include/outcome.hpp:33:3: error: expected identifier before ‘>’ token
33 |   BOOST_OUTCOME_TRY2_SUCCESS_LIKELY(BOOST_OUTCOME_TRY_UNIQUE_NAME, result, expr)
|   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/boost/outcome/try.hpp:159:47: note: in expansion of macro ‘OUTCOME_TRY_INVOKE_TRY2’
159 | #define BOOST_OUTCOME_TRY_OVERLOAD_GLUE(x, y) x y
|                                               ^
/mnt/AUR/orbit-git/src/orbit/src/UserSpaceInstrumentation/AccessTraceesMemory.cpp:55:3: note: in expansion of macro ‘OUTCOME_TRY’
55 |   OUTCOME_TRY(auto&& maps, ReadFileToString(absl::StrFormat("/proc/%d/maps", pid)));
|   ^~~~~~~~~~~
/mnt/AUR/orbit-git/src/orbit/third_party/Outcome/include/outcome.hpp:33:37: error: expected initializer before ‘_outcome_try_unique_name_temporary4_f’
33 |   BOOST_OUTCOME_TRY2_SUCCESS_LIKELY(BOOST_OUTCOME_TRY_UNIQUE_NAME, result, expr)
|                                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/boost/outcome/try.hpp:159:47: note: in expansion of macro ‘OUTCOME_TRY_INVOKE_TRY2’
159 | #define BOOST_OUTCOME_TRY_OVERLOAD_GLUE(x, y) x y
|                                               ^
/mnt/AUR/orbit-git/src/orbit/src/UserSpaceInstrumentation/AccessTraceesMemory.cpp:55:3: note: in expansion of macro ‘OUTCOME_TRY’
55 |   OUTCOME_TRY(auto&& maps, ReadFileToString(absl::StrFormat("/proc/%d/maps", pid)));
|   ^~~~~~~~~~~
/mnt/AUR/orbit-git/src/orbit/third_party/Outcome/include/outcome.hpp:33:3: error: expected ‘>’ before ‘&&’ token
33 |   BOOST_OUTCOME_TRY2_SUCCESS_LIKELY(BOOST_OUTCOME_TRY_UNIQUE_NAME, result, expr)
|   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/boost/outcome/try.hpp:159:47: note: in expansion of macro ‘OUTCOME_TRY_INVOKE_TRY2’
159 | #define BOOST_OUTCOME_TRY_OVERLOAD_GLUE(x, y) x y
|                                               ^
/mnt/AUR/orbit-git/src/orbit/src/UserSpaceInstrumentation/AccessTraceesMemory.cpp:55:3: note: in expansion of macro ‘OUTCOME_TRY’
55 |   OUTCOME_TRY(auto&& maps, ReadFileToString(absl::StrFormat("/proc/%d/maps", pid)));
|   ^~~~~~~~~~~
/mnt/AUR/orbit-git/src/orbit/third_party/Outcome/include/outcome.hpp:33:3: error: expected ‘(’ before ‘&&’ token
33 |   BOOST_OUTCOME_TRY2_SUCCESS_LIKELY(BOOST_OUTCOME_TRY_UNIQUE_NAME, result, expr)
|   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/boost/outcome/try.hpp:159:47: note: in expansion of macro ‘OUTCOME_TRY_INVOKE_TRY2’
159 | #define BOOST_OUTCOME_TRY_OVERLOAD_GLUE(x, y) x y
|                                               ^
/mnt/AUR/orbit-git/src/orbit/src/UserSpaceInstrumentation/AccessTraceesMemory.cpp:55:3: note: in expansion of macro ‘OUTCOME_TRY’
55 |   OUTCOME_TRY(auto&& maps, ReadFileToString(absl::StrFormat("/proc/%d/maps", pid)));
|   ^~~~~~~~~~~
/mnt/AUR/orbit-git/src/orbit/third_party/Outcome/include/outcome.hpp:33:3: error: expected identifier before ‘>’ token
33 |   BOOST_OUTCOME_TRY2_SUCCESS_LIKELY(BOOST_OUTCOME_TRY_UNIQUE_NAME, result, expr)
|   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/boost/outcome/try.hpp:159:47: note: in expansion of macro ‘OUTCOME_TRY_INVOKE_TRY2’
159 | #define BOOST_OUTCOME_TRY_OVERLOAD_GLUE(x, y) x y
|                                               ^
/mnt/AUR/orbit-git/src/orbit/src/UserSpaceInstrumentation/AccessTraceesMemory.cpp:55:3: note: in expansion of macro ‘OUTCOME_TRY’
55 |   OUTCOME_TRY(auto&& maps, ReadFileToString(absl::StrFormat("/proc/%d/maps", pid)));
|   ^~~~~~~~~~~
/mnt/AUR/orbit-git/src/orbit/src/UserSpaceInstrumentation/AccessTraceesMemory.cpp:56:57: error: ‘maps’ was not declared in this scope
56 |   const std::vector<std::string> lines = absl::StrSplit(maps, '\n', absl::SkipEmpty());
|                                                         ^~~~

/mnt/AUR/orbit-git/src/orbit/src/ProcessService/Process.cpp
In file included from /mnt/AUR/orbit-git/src/orbit/third_party/Outcome/include/outcome.hpp:22,
from /mnt/AUR/orbit-git/src/orbit/src/OrbitBase/include/OrbitBase/Result.h:16,
from /mnt/AUR/orbit-git/src/orbit/src/ProcessService/include/ProcessService/Process.h:12,
from /mnt/AUR/orbit-git/src/orbit/src/ProcessService/Process.cpp:5:
/mnt/AUR/orbit-git/src/orbit/src/ProcessService/Process.cpp: In static member function ‘static ErrorMessageOr<orbit_process_service_internal::Process> orbit_process_service_internal::Process::FromPid(uint32_t)’:
/mnt/AUR/orbit-git/src/orbit/third_party/Outcome/include/outcome.hpp:33:3: error: expected primary-expression before ‘)’ token
33 |   BOOST_OUTCOME_TRY2_SUCCESS_LIKELY(BOOST_OUTCOME_TRY_UNIQUE_NAME, result, expr)
|   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/boost/outcome/try.hpp:159:47: note: in expansion of macro ‘OUTCOME_TRY_INVOKE_TRY2’
159 | #define BOOST_OUTCOME_TRY_OVERLOAD_GLUE(x, y) x y
|                                               ^
/mnt/AUR/orbit-git/src/orbit/src/ProcessService/Process.cpp:52:3: note: in expansion of macro ‘OUTCOME_TRY’
52 |   OUTCOME_TRY(const bool is_directory, orbit_base::IsDirectory(path));
|   ^~~~~~~~~~~
/mnt/AUR/orbit-git/src/orbit/third_party/Outcome/include/outcome.hpp:33:3: error: expected ‘>’ before ‘&&’ token
33 |   BOOST_OUTCOME_TRY2_SUCCESS_LIKELY(BOOST_OUTCOME_TRY_UNIQUE_NAME, result, expr)
|   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/boost/outcome/try.hpp:159:47: note: in expansion of macro ‘OUTCOME_TRY_INVOKE_TRY2’
159 | #define BOOST_OUTCOME_TRY_OVERLOAD_GLUE(x, y) x y
|                                               ^
/mnt/AUR/orbit-git/src/orbit/src/ProcessService/Process.cpp:52:3: note: in expansion of macro ‘OUTCOME_TRY’
52 |   OUTCOME_TRY(const bool is_directory, orbit_base::IsDirectory(path));
|   ^~~~~~~~~~~
/mnt/AUR/orbit-git/src/orbit/third_party/Outcome/include/outcome.hpp:33:3: error: expected ‘(’ before ‘&&’ token
33 |   BOOST_OUTCOME_TRY2_SUCCESS_LIKELY(BOOST_OUTCOME_TRY_UNIQUE_NAME, result, expr)
|   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/boost/outcome/try.hpp:159:47: note: in expansion of macro ‘OUTCOME_TRY_INVOKE_TRY2’
159 | #define BOOST_OUTCOME_TRY_OVERLOAD_GLUE(x, y) x y
|                                               ^
/mnt/AUR/orbit-git/src/orbit/src/ProcessService/Process.cpp:52:3: note: in expansion of macro ‘OUTCOME_TRY’
52 |   OUTCOME_TRY(const bool is_directory, orbit_base::IsDirectory(path));
|   ^~~~~~~~~~~
/mnt/AUR/orbit-git/src/orbit/third_party/Outcome/include/outcome.hpp:33:3: error: expected identifier before ‘>’ token
33 |   BOOST_OUTCOME_TRY2_SUCCESS_LIKELY(BOOST_OUTCOME_TRY_UNIQUE_NAME, result, expr)
|   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/boost/outcome/try.hpp:159:47: note: in expansion of macro ‘OUTCOME_TRY_INVOKE_TRY2’
159 | #define BOOST_OUTCOME_TRY_OVERLOAD_GLUE(x, y) x y
|                                               ^
/mnt/AUR/orbit-git/src/orbit/src/ProcessService/Process.cpp:52:3: note: in expansion of macro ‘OUTCOME_TRY’
52 |   OUTCOME_TRY(const bool is_directory, orbit_base::IsDirectory(path));
|   ^~~~~~~~~~~
/mnt/AUR/orbit-git/src/orbit/third_party/Outcome/include/outcome.hpp:33:37: error: expected initializer before ‘_outcome_try_unique_name_temporary0_f’
33 |   BOOST_OUTCOME_TRY2_SUCCESS_LIKELY(BOOST_OUTCOME_TRY_UNIQUE_NAME, result, expr)
|                                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/boost/outcome/try.hpp:159:47: note: in expansion of macro ‘OUTCOME_TRY_INVOKE_TRY2’
159 | #define BOOST_OUTCOME_TRY_OVERLOAD_GLUE(x, y) x y
|                                               ^
/mnt/AUR/orbit-git/src/orbit/src/ProcessService/Process.cpp:52:3: note: in expansion of macro ‘OUTCOME_TRY’
52 |   OUTCOME_TRY(const bool is_directory, orbit_base::IsDirectory(path));
|   ^~~~~~~~~~~
/mnt/AUR/orbit-git/src/orbit/third_party/Outcome/include/outcome.hpp:33:3: error: expected ‘>’ before ‘&&’ token
33 |   BOOST_OUTCOME_TRY2_SUCCESS_LIKELY(BOOST_OUTCOME_TRY_UNIQUE_NAME, result, expr)
|   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/boost/outcome/try.hpp:159:47: note: in expansion of macro ‘OUTCOME_TRY_INVOKE_TRY2’
159 | #define BOOST_OUTCOME_TRY_OVERLOAD_GLUE(x, y) x y
|                                               ^
/mnt/AUR/orbit-git/src/orbit/src/ProcessService/Process.cpp:52:3: note: in expansion of macro ‘OUTCOME_TRY’
52 |   OUTCOME_TRY(const bool is_directory, orbit_base::IsDirectory(path));
|   ^~~~~~~~~~~
/mnt/AUR/orbit-git/src/orbit/third_party/Outcome/include/outcome.hpp:33:3: error: expected ‘(’ before ‘&&’ token
33 |   BOOST_OUTCOME_TRY2_SUCCESS_LIKELY(BOOST_OUTCOME_TRY_UNIQUE_NAME, result, expr)
|   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/boost/outcome/try.hpp:159:47: note: in expansion of macro ‘OUTCOME_TRY_INVOKE_TRY2’
159 | #define BOOST_OUTCOME_TRY_OVERLOAD_GLUE(x, y) x y
|                                               ^
/mnt/AUR/orbit-git/src/orbit/src/ProcessService/Process.cpp:52:3: note: in expansion of macro ‘OUTCOME_TRY’
52 |   OUTCOME_TRY(const bool is_directory, orbit_base::IsDirectory(path));
|   ^~~~~~~~~~~
/mnt/AUR/orbit-git/src/orbit/third_party/Outcome/include/outcome.hpp:33:3: error: expected identifier before ‘>’ token
33 |   BOOST_OUTCOME_TRY2_SUCCESS_LIKELY(BOOST_OUTCOME_TRY_UNIQUE_NAME, result, expr)
|   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/boost/outcome/try.hpp:159:47: note: in expansion of macro ‘OUTCOME_TRY_INVOKE_TRY2’
159 | #define BOOST_OUTCOME_TRY_OVERLOAD_GLUE(x, y) x y
|                                               ^
/mnt/AUR/orbit-git/src/orbit/src/ProcessService/Process.cpp:52:3: note: in expansion of macro ‘OUTCOME_TRY’
52 |   OUTCOME_TRY(const bool is_directory, orbit_base::IsDirectory(path));
|   ^~~~~~~~~~~
/mnt/AUR/orbit-git/src/orbit/src/ProcessService/Process.cpp:53:8: error: ‘is_directory’ was not declared in this scope; did you mean ‘std::filesystem::is_directory’?
53 |   if (!is_directory) {
|        ^~~~~~~~~~~~
|        std::filesystem::is_directory
In file included from /usr/include/c++/12.2.1/filesystem:47,
from /mnt/AUR/orbit-git/src/orbit/src/ProcessService/Process.cpp:11:
/usr/include/c++/12.2.1/bits/fs_ops.h:203:3: note: ‘std::filesystem::is_directory’ declared here
203 |   is_directory(const path& __p, error_code& __ec) noexcept
|   ^~~~~~~~~~~~

[beckerhe]

There was probably a breaking change in one of the later versions of Boost. I can try to have a look towards the end of the week, but I can't promise.

If you happen to have a fix feel free to create a PR. :-)