Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP Headers of PATCH Blob Chunk uploads do not match OCI Spec #59

Open
containerdude opened this issue Jun 25, 2021 · 0 comments
Open

Comments

@containerdude
Copy link

containerdude commented Jun 25, 2021

Hi,

I'm seeing some instability with nodejs-container-image-builder and blob uploads against AWS ECR. I believe that this may be because the library is not quite spec compliant. This results in requests that sometimes succeed and sometimes fail - not good in my CICD pipeline.

I call image.addFiles({'target/':'src/'}) and it appears that the underlying PATCH call that this generates matches OCI spec endpoint end-5.

Per the spec, the following request headers are mandatory:

Content-Type: application/octet-stream
Content-Range: <range>
Content-Length: <length>

However it seems that only Content-Type is actually sent with the request.

I would be grateful for any assistance in getting this resolved. Unfortunately job constraints preventing me from signing any CLA around this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant